Page MenuHomePhabricator

Feature flag editing functionality within the sticky header
Closed, ResolvedPublic

Description

Background

Based on some of the blockers identified in T293158: Clicking the sticky header edit icon should not reload the page, it seems probable that the current implementation of the sticky header cannot retain the scroll position when the edit link is selected (due to the current nature of VE). This task will create a feature flag for the editing functionality that will allow for the sticky header to be deployed independently of editing functionality until this and other blockers outlined in T287545: [EPIC] Introduce editing functionality to the sticky header are resolved

Acceptance criteria

  • Feature flag edit buttons within the sticky header

QA

QA Results - Beta

QA Results - Prod

Details

Related Changes in Gerrit:

Event Timeline

Change 734743 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Add sticky header edit feature flag

https://gerrit.wikimedia.org/r/734743

Change 734743 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add sticky header edit feature flag

https://gerrit.wikimedia.org/r/734743

@Jdlrobson - does the feature flag implemented here also affect protected pages? I realized we hadn't discussed this previously while signing off the task for the new icon for protected pages.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visiting https://en.wikipedia.beta.wmflabs.org/wiki/Albert%20Einstein?vectorstickyheaderedit=0 and confirm the edit icons do not show.

Screen Shot 2021-11-04 at 6.13.01 AM.png (1×926 px, 397 KB)

✅ AC2: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Albert%20Einstein?vectorstickyheaderedit=1 and confirm the edit icons show
Screen Shot 2021-11-04 at 6.13.57 AM.png (1×926 px, 454 KB)

✅ AC3: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Protected_page?vectorstickyheaderedit=1 and confirm the protected edit icon shows.
Screen Shot 2021-11-04 at 6.14.28 AM.png (1×926 px, 312 KB)

✅ AC4: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Protected_page?vectorstickyheaderedit=0 and confirm no edit icon shows.
Screen Shot 2021-11-04 at 6.15.04 AM.png (1×926 px, 313 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visiting https://en.wikipedia.org/wiki/Albert%20Einstein?vectorstickyheader=1&vectorstickyheaderedit=0 and confirm the edit icons do not show.

Screen Shot 2021-11-09 at 3.43.22 PM.png (1×1 px, 599 KB)

✅ AC2: https://en.wikipedia.org/wiki/Paul_Haines_(poet)?vectorstickyheader=1&vectorstickyheaderedit=1 and confirm the edit icons show
Screen Shot 2021-11-09 at 3.45.27 PM.png (1×1 px, 394 KB)

✅ AC3: Visit https://en.wikipedia.org/wiki/Albert%20Einstein?vectorstickyheader=1&vectorstickyheaderedit=1 and confirm the protected edit icon shows.
Screen Shot 2021-11-09 at 3.45.39 PM.png (1×1 px, 652 KB)

✅ AC4: Visit https://en.wikipedia.org/wiki/Albert%20Einstein?vectorstickyheader=1&vectorstickyheaderedit=0 and confirm no edit icon shows.
Screen Shot 2021-11-09 at 3.47.04 PM.png (1×1 px, 543 KB)