Page MenuHomePhabricator
Create Task
Maniphest T294388

Run some full end-to-end browser integration tests on Beta Cluster Wikifunctions now it exists
Closed, ResolvedPublic
Actions

Description

For other critical extensions, on top of the blocking-CI selenium tests which stop us from landing changes that break our tests, we also have daily jobs that run on the Beta Cluster with the full gamut of production code, e.g. for AdvancedSearch or VisualEditor. It would be a good step for peace of mind to do the same for WikiLambda / Wikifunctions.

Details

SubjectRepoBranchLines +/-
package: Define 'selenium-daily' job, for now same as all testsmediawiki/extensions/WikiLambdamaster+1 -0
Zuul: [mediawiki/extensions/WikiLambda] Disable selenium testsintegration/configmaster+8 -4
jjb: Define selenium-daily-betawikifunctions-WikiLambdaintegration/configmaster+14 -0
Use Beta Cluster by default and wire-up end-to-end testsmediawiki/extensions/WikiLambdamaster+203 -213
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedSDunlapT294388 Run some full end-to-end browser integration tests on Beta Cluster Wikifunctions now it exists
 ResolvedSDunlapT276847 Write a suite of user experience end-to-end integration tests for WikiLambda in selenium/etc. sufficient for us to launch with
 ResolvedTeleosteenT321932 E2E test for CUJ 1: Evaluate a function
 ResolvedTeleosteenT321933 E2E test for CUJ 2: Create a function definition
 ResolvedDVrandecicT318930 CUJ 2: Create a function definition
 ResolvedDVrandecicT323804 Design: create a function definition
 ResolvedDdwaalT321399 Don't show / disable the "show more languages" / "Show name in other languages" buttons when there aren't any to show
 ResolvedDdwaalT321396 Copy: Evaluate copy on function viewer details tab
 ResolvedNik.xyz.inT321934 E2E test for CUJ 3: Edit a function definition
 ResolvedDVrandecicT318933 CUJ 3: Edit a function definition
 ResolvedDVrandecicT318314 Function editor: Remove an item from the list of arguments
 Resolved• AdesojiThisDotT318315 Function editor: Implement functionality of "remove input field" using the Mobile view button.
 ResolvedDdwaalT318317 Function editor: Implement "remove input field" button for Desktop view
 ResolvedAAlhazwani-WMFT312121 The dropdown menu of the "output type" from the function definition page is hidden under another component
 ResolvedNoneT323805 Design: edit a function definition
 ResolvedaishwaryavardhanaT285418 A way to easily and intuitively create and edit functions
 ResolvedaishwaryavardhanaT285419 Initial user flow diagrams for function editor
 InvalidaishwaryavardhanaT285421 Generative design research: Testing of new hypotheses and mental models
 DeclinedSWoodruff-WMFT285422 Function editor: User education, interface copy, notifications and alerts
 DeclinedSWoodruff-WMFT285684 As someone who is new to creating functions, I would like to be able to start with an easy task
 ResolvedaishwaryavardhanaT296693 Desktop designs for function editor v1
 Resolved• AdesojiThisDotT297086 Function Editor - Sidebar - Language selector
 Declined• AdesojiThisDotT298203 Provide an easy way on the front-end for Wikifunctions to know what languages are supported (and what their ZIDs are)
 ResolvedSimoneThisDotT297095 Function Editor - Function Definition - New component
 Resolved• JKiesermanT297098 Function Editor - Function definition - Heading
 Resolved• AdesojiThisDotT297099 Function Editor - Enhance the "Object selector" to allow user to type within its first entry instead than the input itself to align with the designs
 ResolvedSimoneThisDotT297100 Function Editor - Create the function definition main content area
 Resolved• AdesojiThisDotT297101 Function Editor - Allow user to add labels in another language in function definition
 Resolved• JKiesermanT297104 Function Editor - Provide the ability for users to publish, write implementation and cancel function
 Resolved• JKiesermanT297271 Function Editor - Create an Chip component
 Resolved• AdesojiThisDotT297280 Function Editor - sidebar - Update diagram
 ResolvedgenghT297869 Function Editor: Allow user to REMOVE an Input from a function definition
 ResolvedSimoneThisDotT298464 Remove old function editor and its files
 ResolvedaishwaryavardhanaT296698 Provide a UX design for function viewing
 ResolvedSimoneThisDotT301518 Explore replacing the legacy function editor with fallback to the generic editor via a button, so that functions can be connected to implementations and testers and we can scrap the legacy function editor
 ResolvedaishwaryavardhanaT296694 Mobile designs for function editor v1
 ResolvedaishwaryavardhanaT296696 Provide a compelling, scalable, validated UX design for function creation and editing
 ResolvedaishwaryavardhanaT297458 User flow for when a user edits definition
 ResolvedaishwaryavardhanaT297462 User flow when a user only edits labels
 ResolvedaishwaryavardhanaT297463 User flow for how a user would complete multilingual edits
 ResolvedNoneT297464 Decide on the UX design for the edit summary
 ResolvedaishwaryavardhanaT297465 Design notes for if an input type is changed
 ResolvedaishwaryavardhanaT297466 Design notes for if an output type is changed
 ResolvedaishwaryavardhanaT297467 Decide on the UX design for attaching and detatching (but not editing) implementations and testers
 ResolvedaishwaryavardhanaT297668 Revisit user flows for function editor
 ResolvedSWoodruff-WMFT318316 Function editor: Design function argument (input) delete button/icon for Desktop view.
 ResolvedAAlhazwani-WMFT320410 Design: Function editor, redefine separation between fields and blocks.
 ResolvedAAlhazwani-WMFT270304 Design a "Publish" component
 ResolvedSimoneThisDotT268296 Display to user why an object is not stored
 DuplicateNoneT274424 Show errors if creation of ZObject fails
 ResolvedDVrandecicT316686 Copy: change text for confirmation dialog when creating a new function on mobile
 ResolvedDVrandecicT303336 Users can write an edit summary when publishing which can be seen by other users in histories
 ResolvedDVrandecicT299004 Have the publish function enable/disable itself only if there have been changes
 ResolvedgenghT326656 FunctionEditor: Implement separation between fields and blocks changes
 ResolvedNik.xyz.inT321935 E2E test for CUJ 4: Create tester for function
 ResolvedDVrandecicT318938 CUJ 4: Create tests
 InvalidNoneT323806 Design: create tests
 ResolvedNik.xyz.inT321937 E2E test for CUJ 5: Create implementations with code
 ResolvedNik.xyz.inT321939 E2E test for CUJ 6: Connect an implementation or test to a function
 ResolvedDVrandecicT318936 CUJ 6: Connect an implementation or test to a function
 ResolvedDVrandecicT323808 Design: connect an implementation or test to a function
 ResolvedDdwaalT320278 Copy: Language for "connecting" an implementation or tester to a ZFunction
 ResolvedDdwaalT318426 Tests: Implement FE integration test for connecting implementations and testers to functions
 ResolvedSDunlapT321942 make E2E test suit runnable via "helm test"
 ResolvedNik.xyz.inT321938 E2E test for CUJ 5: Create implementations with composition
 ResolvedNik.xyz.inT318939 CUJ 5: Add implementations via code or composition
 InvalidNoneT323807 Design: add implementations via code or composition
 OpenNoneT324155 Clean up created objects (e.g. functions) after successful e2e test run

Event Timeline

Jdforrester-WMF created this task.Oct 26 2021, 8:23 PM
DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Oct 27 2021, 4:12 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
gerritbot added a comment.Jun 6 2022, 5:51 PM

Change 803330 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [DNM] Use Beta Cluster by default and wire-up end-to-end tests

https://gerrit.wikimedia.org/r/803330

gerritbot added a project: Patch-For-Review.Jun 6 2022, 5:51 PM
gerritbot added a comment.Jul 19 2022, 8:49 PM

Change 803330 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Use Beta Cluster by default and wire-up end-to-end tests

https://gerrit.wikimedia.org/r/803330

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 19 2022, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 19 2022, 9:30 PM
Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:32 PM
Jdforrester-WMF added a subtask: T276847: Write a suite of user experience end-to-end integration tests for WikiLambda in selenium/etc. sufficient for us to launch with.Oct 25 2022, 1:43 PM
Jdforrester-WMF renamed this task from Run some full end-to-end browser integration tests on Beta Cluster Wikifunctions once it exists to Run some full end-to-end browser integration tests on Beta Cluster Wikifunctions now it exists.Oct 25 2022, 6:52 PM
Jdforrester-WMF added a project: Continuous-Integration-Config.Oct 25 2022, 6:57 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Nov 14 2022, 7:10 PM

Change 856646 had a related patch set uploaded (by Stef Dunlap; author: Stef Dunlap):

[integration/config@master] WikiLambda: run e2e tests daily on betacluster

https://gerrit.wikimedia.org/r/856646

gerritbot added a project: Patch-For-Review.Nov 14 2022, 7:10 PM
zeljkofilipin added a project: User-zeljkofilipin.Nov 15 2022, 9:10 AM
zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Nov 17 2022, 5:56 PM

Change 858394 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Define selenium-daily-betawikifunctions-WikiLambda

https://gerrit.wikimedia.org/r/858394

gerritbot added a comment.Nov 17 2022, 7:30 PM

Change 858394 merged by jenkins-bot:

[integration/config@master] jjb: Define selenium-daily-betawikifunctions-WikiLambda

https://gerrit.wikimedia.org/r/858394

gerritbot added a comment.Nov 21 2022, 2:54 PM

Change 856646 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/WikiLambda] Disable selenium tests

https://gerrit.wikimedia.org/r/856646

Stashbot added a comment.Nov 21 2022, 2:54 PM

Mentioned in SAL (#wikimedia-releng) [2022-11-21T14:54:56Z] <James_F> Zuul: [mediawiki/extensions/WikiLambda] Disable selenium tests for T294388

Jdforrester-WMF updated the task description. (Show Details)Nov 21 2022, 3:02 PM
gerritbot added a comment.Nov 21 2022, 3:08 PM

Change 859088 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] package: Define 'selenium-daily' job, for now same as all tests

https://gerrit.wikimedia.org/r/859088

zeljkofilipin added a subscriber: zeljkofilipin.Nov 21 2022, 3:57 PM
gerritbot added a comment.Nov 21 2022, 3:57 PM

Change 859088 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] package: Define 'selenium-daily' job, for now same as all tests

https://gerrit.wikimedia.org/r/859088

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 21 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 21 2022, 4:30 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Nov 22 2022, 12:56 PM

The selenium-daily-betawikifunctions-WikiLambda job is deployed and running. Can this task be resolved or is there something left to do?

Jdforrester-WMF added a comment.Nov 23 2022, 2:57 PM
In T294388#8412737, @zeljkofilipin wrote:

The selenium-daily-betawikifunctions-WikiLambda job is deployed and running. Can this task be resolved or is there something left to do?

We should probably actually have some end-to-end tests first. :-) It looks like T321932 will land first.

zeljkofilipin added a comment.Nov 28 2022, 1:07 PM

Sorry, I didn't take a good look. Looks like existing tests are really basic.

zeljkofilipin moved this task from Waiting 🏹 to Watching 📺 on the User-zeljkofilipin board.Nov 28 2022, 1:07 PM
SDunlap added a subtask: T324155: Clean up created objects (e.g. functions) after successful e2e test run.Nov 30 2022, 9:38 PM
Ayush_Anand3310 added a subscriber: Ayush_Anand3310.Feb 25 2023, 9:50 PM
Ayush_Anand3310 added a comment.Feb 25 2023, 9:57 PM

@Jdforrester-WMF I want to work on this task. I am a beginner on this project. Can you share some resources to get started?

Restricted Application added a comment. · View Herald TranscriptFeb 25 2023, 9:57 PM

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

hashar removed a project: Continuous-Integration-Config.Feb 28 2023, 2:11 PM
Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 1:25 AM
Jdforrester-WMF closed this task as Resolved.Jun 7 2023, 5:49 PM
Jdforrester-WMF assigned this task to SDunlap.

Done by Stef a while ago.

DVrandecic closed subtask T276847: Write a suite of user experience end-to-end integration tests for WikiLambda in selenium/etc. sufficient for us to launch with as Resolved.Jul 6 2023, 12:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL