Page MenuHomePhabricator
Create Task
Maniphest T294421

Recent changes mentorship filters: Starred mentees filter is ignored if user has no starred mentees
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enroll as a Growth mentor on cs.wikipedia
  • Go to your mentor dashboard, ensure you have no starred mentees (can be forced by setting growthexperiments-starred-mentees user preference to an empty string)
  • Go to recent changes, and check "Your starred mentees"

What happens?:

Special:RecentChanges shows information about all changes.

What should have happened instead?:

Special:RecentChanges shows no changes, as no changes match the filters.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Mentor dashboard: Fix empty set handling in RC filtermediawiki/extensions/GrowthExperimentsmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Oct 27 2021, 10:29 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 27 2021, 10:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF added a subscriber: Tgr.Oct 27 2021, 10:31 AM

Discovered when fixing T294386: InvalidArgumentException: Wikimedia\Rdbms\Database::makeList: empty input for field recentchanges_actor.actor_user.

@Tgr Any idea why that would happen? I'm starring at the MentorFilterHooks, and I have the feeling it's caused by a bug in MediaWiki-Recent-changes rather than in GrowthExperiments extension.

• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Oct 27 2021, 11:40 PM
Tgr added a comment.Nov 10 2021, 8:59 PM

I side effect of rEGRE3016bd58fffb: MentorFilterHooks: Account for no matching users I think. When the set of eligible users is empty, I guess we should add an impossible condition?

gerritbot added a comment.Nov 10 2021, 9:04 PM

Change 738009 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Fix empty set handling in RC filter

https://gerrit.wikimedia.org/r/738009

gerritbot added a project: Patch-For-Review.Nov 10 2021, 9:04 PM
Urbanecm_WMF added a comment.Nov 11 2021, 9:54 AM
In T294421#7497214, @Tgr wrote:

I side effect of rEGRE3016bd58fffb: MentorFilterHooks: Account for no matching users I think. When the set of eligible users is empty, I guess we should add an impossible condition?

Of course, thanks for noticing&fixing!

Urbanecm_WMF assigned this task to Tgr.Nov 11 2021, 9:54 AM
Urbanecm_WMF triaged this task as Medium priority.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 11 2021, 10:14 AM

Change 738009 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Fix empty set handling in RC filter

https://gerrit.wikimedia.org/r/738009

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 11 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 11 2021, 11:10 AM
QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 6:20 PM
Etonkovidova closed this task as Resolved.Dec 16 2021, 12:30 AM
Etonkovidova subscribed.

Checked on testwiki wmf.13 - RC filters work as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits