Page MenuHomePhabricator

Recent changes mentorship filters: Starred mentees filter is ignored if user has no starred mentees
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enroll as a Growth mentor on cs.wikipedia
  • Go to your mentor dashboard, ensure you have no starred mentees (can be forced by setting growthexperiments-starred-mentees user preference to an empty string)
  • Go to recent changes, and check "Your starred mentees"

What happens?:

Special:RecentChanges shows information about all changes.

What should have happened instead?:

Special:RecentChanges shows no changes, as no changes match the filters.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Discovered when fixing T294386: InvalidArgumentException: Wikimedia\Rdbms\Database::makeList: empty input for field recentchanges_actor.actor_user.

@Tgr Any idea why that would happen? I'm starring at the MentorFilterHooks, and I have the feeling it's caused by a bug in MediaWiki-Recent-changes rather than in GrowthExperiments extension.

I side effect of rEGRE3016bd58fffb: MentorFilterHooks: Account for no matching users I think. When the set of eligible users is empty, I guess we should add an impossible condition?

Change 738009 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Fix empty set handling in RC filter

https://gerrit.wikimedia.org/r/738009

I side effect of rEGRE3016bd58fffb: MentorFilterHooks: Account for no matching users I think. When the set of eligible users is empty, I guess we should add an impossible condition?

Of course, thanks for noticing&fixing!

Urbanecm_WMF triaged this task as Medium priority.
Urbanecm_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.

Change 738009 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Fix empty set handling in RC filter

https://gerrit.wikimedia.org/r/738009

Etonkovidova added a subscriber: Etonkovidova.

Checked on testwiki wmf.13 - RC filters work as expected.