Follow the steps in the "test plan" section of the parent task: T289019: Test Vue 3 migration build with extensions/skins using Vue. The outcome of this task should be that NearbyPages runs without errors both under Vue 2 and under the Vue 3 migration build.
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/NearbyPages | master | +16 -8 | Make Nearby use createMwApp |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | • STH | T302350 <Core Technology> Upgrade MediaWiki to Vue 3 | |||
| Stalled | None | T289017 [EPIC] <Core Technology> Upgrade MediaWiki projects from Vue 2 to Vue 3 | |||
| Resolved | None | T289019 Test Vue 3 migration build with extensions/skins using Vue | |||
| Resolved | Catrope | T294473 Make NearbyPages work with the Vue 3 migration build |
Event Timeline
Comment Actions
NearbyPages works fine in Vue 3 without errors or meaningful migration warnings (only the usual ones caused by MW core and WVUI).
Comment Actions
Eventually yes, but for now it's fine without. Compatibility is provided for new Vue(), so the existing code works as-is. It throws a warning that new Vue() is deprecated and you should switch to Vue.createMwApp(), but that can be dealt with in the next stage of the migration, together with any other migration warnings.
Comment Actions
Change 743004 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/NearbyPages@master] Make Nearby use createMwApp
Comment Actions
Change 743004 merged by jenkins-bot:
[mediawiki/extensions/NearbyPages@master] Make Nearby use createMwApp