Page MenuHomePhabricator

Make NearbyPages work with the Vue 3 migration build
Closed, ResolvedPublic


Follow the steps in the "test plan" section of the parent task: T289019: Test Vue 3 migration build with extensions/skins using Vue. The outcome of this task should be that NearbyPages runs without errors both under Vue 2 and under the Vue 3 migration build.

Event Timeline

Catrope claimed this task.

NearbyPages works fine in Vue 3 without errors or meaningful migration warnings (only the usual ones caused by MW core and WVUI).

@Catrope does NearbyPages need to call createMwApp ?

@Catrope does NearbyPages need to call createMwApp ?

Eventually yes, but for now it's fine without. Compatibility is provided for new Vue(), so the existing code works as-is. It throws a warning that new Vue() is deprecated and you should switch to Vue.createMwApp(), but that can be dealt with in the next stage of the migration, together with any other migration warnings.

I'll submit a patch shortly as I think it will be easier to address them in advance.

Change 743004 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/NearbyPages@master] Make Nearby use createMwApp

Change 743004 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] Make Nearby use createMwApp