Page MenuHomePhabricator

GrowthExperiments SuggestedEdits module gets confused when selected task types don't exist
Open, Needs TriagePublic

Description

Steps to reproduce:

You'll end up with an empty task filter list but lots of tasks in your feed.

Similar error happens if a user does have prior task type settings but those task types don't exist anymore.

What's happening is that the API interprets an empty list of task types as "give me all types" (it's a convenience so people don't need to manually enter each). Normally the UI prevents you from deselecting all task types, so this can't happen, but when the default types don't exist, the filter starts with all types unselected.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mewoph added a subscriber: mewoph.

Moving to Needs Discussion to determine the course(s) of action:
Impact: Users in the control group in wikis where there are no copyedit and (unstructured) link tasks will see an empty filter but all possible tasks are in the feed.
Possible actions (from @Tgr's comment in the original task)

  • Fallback chain of default task types
  • Allow the default task types to be configured via community configuration
Tgr renamed this task from GrowthExperiments SuggestedEdits module gets confused when default task types don't exist to GrowthExperiments SuggestedEdits module gets confused when slelected task types don't exist.Jan 13 2022, 1:32 AM
Tgr updated the task description. (Show Details)

After checking T294518: Add Image: Allow disabling feature via community configuration and to add more on the following use case, I added the description of the current behavior:

You'll end up with an empty task filter list but lots of tasks in your feed.

Similar error happens if a user does have prior task type settings but those task types don't exist anymore.

(1) The task types filters (after disabling some tasks on Special:EditGrowthConfig) would not display any pre-selected task types. A user would be facing with un-selected tasks types filters.

Screen Shot 2022-01-12 at 3.30.37 PM.png (1×1 px, 228 KB)

Users should either see new default task types selected or be forced/warned to select new task types.

(2) The first SE card would be loaded. The right hand navigation (the arrows) would look active, but if a user clicks on the navigation arrow, the incorrect counter and the warning would be displayed:

Screen Shot 2022-01-12 at 3.30.23 PM.png (1×1 px, 97 KB)

Tgr renamed this task from GrowthExperiments SuggestedEdits module gets confused when slelected task types don't exist to GrowthExperiments SuggestedEdits module gets confused when selected task types don't exist.Jan 13 2022, 2:59 AM