Page MenuHomePhabricator
Create Task
Maniphest T294601

[betalabs] 'imagerecommendation' variant fails fetching articles
Closed, ResolvedPublic
Actions

Description

Use ge.utils.setUserVariant('imagerecommendation') in the Console on Homepage.
No articles will be fetched:

Screen Shot 2021-10-28 at 2.23.27 PM.png (1×1 px, 112 KB)

Fetching task suggestions failed: internal_api_error_Error internal_api_error_Error 
{error: {…}, servedby: 'deployment-mediawiki11'}
GrowthTasksApi.handleError

Reload the page - the Internal error page is displayed:

[YXsRu@HPmTQn--YAQMS2-gAAABQ] /w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=-1 Error: Cannot use object of type stdClass as array

Backtrace:

from /srv/mediawiki/php-master/vendor/ruflin/elastica/lib/Elastica/Param.php(172)
#0 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/Filters.php(78): Elastica\Param->hasParam(string)
#1 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/SearchContext.php(563): CirrusSearch\Search\Filters::unify(array, array)
#2 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/SearchRequestBuilder.php(66): CirrusSearch\Search\SearchContext->getQuery()
#3 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Searcher.php(489): CirrusSearch\Search\SearchRequestBuilder->build()
#4 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Searcher.php(321): CirrusSearch\Searcher->buildSearch()
#5 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Searcher.php(215): CirrusSearch\Searcher->searchTextInternal(string)
#6 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(299): CirrusSearch\Searcher->search(CirrusSearch\Search\SearchQuery)
#7 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(272): CirrusSearch\CirrusSearch->searchTextReal(CirrusSearch\Search\SearchQuery)
#8 /srv/mediawiki/php-master/includes/search/SearchEngine.php(95): CirrusSearch\CirrusSearch->doSearchText(string)
#9 /srv/mediawiki/php-master/includes/search/SearchEngine.php(187): SearchEngine->{closure}()
#10 /srv/mediawiki/php-master/includes/search/SearchEngine.php(96): SearchEngine->maybePaginate(Closure)
#11 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/LocalSearchTaskSuggester.php(71): SearchEngine->searchText(string)
#12 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/SearchTaskSuggester.php(182): GrowthExperiments\NewcomerTasks\TaskSuggester\LocalSearchTaskSuggester->search(GrowthExperiments\NewcomerTasks\TaskSuggester\SearchStrategy\SearchQuery, integer, integer, boolean)
#13 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/SearchTaskSuggester.php(94): GrowthExperiments\NewcomerTasks\TaskSuggester\SearchTaskSuggester->doSuggest(NULL, User, array, array, integer, integer, array)
#14 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/CacheDecorator.php(133): GrowthExperiments\NewcomerTasks\TaskSuggester\SearchTaskSuggester->suggest(User, array, array, integer, NULL, array)
#15 /srv/mediawiki/php-master/includes/libs/objectcache/wancache/WANObjectCache.php(1771): GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator->GrowthExperiments\NewcomerTasks\TaskSuggester\{closure}(GrowthExperiments\NewcomerTasks\Task\TaskSet, integer, array, double, array)
#16 /srv/mediawiki/php-master/includes/libs/objectcache/wancache/WANObjectCache.php(1600): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#17 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/CacheDecorator.php(167): WANObjectCache->getWithSetCallback(string, integer, Closure, array)
#18 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php(392): GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator->suggest(User, array, array, integer, NULL, array)
#19 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php(180): GrowthExperiments\HomepageModules\SuggestedEdits->getTaskSet()
#20 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/Homepage/HomepageModuleRegistry.php(116): GrowthExperiments\HomepageModules\SuggestedEdits->__construct(RequestContext, GrowthExperiments\Config\GrowthExperimentsMultiConfig, GrowthExperiments\AqsEditInfoService, GrowthExperiments\ExperimentUserManager, MediaWiki\Extensions\PageViewInfo\CachedPageViewService, GrowthExperiments\NewcomerTasks\ConfigurationLoader\PageConfigurationLoader, GrowthExperiments\NewcomerTasks\NewcomerTasksUserOptionsLookup, GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator, TitleFactory, GrowthExperiments\NewcomerTasks\ProtectionFilter, MediaWiki\User\UserOptionsManager)
#21 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/Homepage/HomepageModuleRegistry.php(55): GrowthExperiments\Homepage\HomepageModuleRegistry::GrowthExperiments\Homepage\{closure}(MediaWiki\MediaWikiServices, RequestContext)
#22 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(225): GrowthExperiments\Homepage\HomepageModuleRegistry->get(string, RequestContext)
#23 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(127): GrowthExperiments\Specials\SpecialHomepage->getModules(boolean, NULL)
#24 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(647): GrowthExperiments\Specials\SpecialHomepage->execute(NULL)
#25 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1377): SpecialPage->run(NULL)
#26 /srv/mediawiki/php-master/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#27 /srv/mediawiki/php-master/includes/MediaWiki.php(925): MediaWiki->performRequest()
#28 /srv/mediawiki/php-master/includes/MediaWiki.php(559): MediaWiki->main()
#29 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#30 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#31 /srv/mediawiki/w/index.php(3): require(string)
#32 {main}

Details

SubjectRepoBranchLines +/-
Add Image: Fix TemplateCollectionFeaturemediawiki/extensions/GrowthExperimentsmaster+23 -30
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Oct 28 2021, 9:26 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 28 2021, 9:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as High priority.Oct 28 2021, 9:52 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)), Image-Suggestions; removed Growth-Team.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Probably related to rEGRE3790c4c37e1d: Search: Add TemplateCollectionFeature

Tgr added subscribers: dcausse, EBernhardson.Oct 29 2021, 4:21 AM

This is caused by an empty template list. It seems to boil down to a weird Elastica bug (that we hit when Filter:booleanOr() is called with an empty array and returns a MatchAll query):

tgr@mwdebug1001:~$ mwscript shell.php testwiki
Psy Shell v0.10.8 (PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf2 — cli) by Justin Hileman
>>> $query = new Elastica\Query\MatchAll()
=> Elastica\Query\MatchAll {#3342}
>>> $query->hasParam('param')
PHP Error:  Cannot use object of type stdClass as array in /srv/mediawiki/php-1.38.0-wmf.6/vendor/ruflin/elastica/lib/Elastica/Param.php on line 172

MatchAll's constructor sets the param field to an stdClass, but everything else expects it to be an array.

@EBernhardson @dcausse any advice on whether we should be doing something differently in TemplateCollectionFeature?

When I try to fix it via $matchAll->setParams( [] ) it avoids the error but the ElasticSearch backend returns query malformed, no start_object after query name.

For the time being, can be worked around with something like Filters::booleanOr( [ new MatchAll(), new MatchAll() ] ).

gerritbot added a comment.Oct 29 2021, 4:34 AM

Change 735473 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Fix TemplateCollectionFeature

https://gerrit.wikimedia.org/r/735473

gerritbot added a project: Patch-For-Review.Oct 29 2021, 4:34 AM
Tgr claimed this task.Oct 29 2021, 4:35 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova mentioned this in T294619: Community configuration edit link does not work on Minerva.Oct 29 2021, 9:41 PM
kostajh mentioned this in T294685: Image recommendation does not work in beta: Exception caught: Cannot use object of type stdClass as array.Oct 30 2021, 2:38 PM
kostajh merged a task: T294685: Image recommendation does not work in beta: Exception caught: Cannot use object of type stdClass as array.
kostajh added a subscriber: Urbanecm_WMF.
gerritbot added a comment.Nov 1 2021, 5:56 PM

Change 735473 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Fix TemplateCollectionFeature

https://gerrit.wikimedia.org/r/735473

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 1 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 1 2021, 6:10 PM
Etonkovidova moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 8 2021, 6:38 PM
Etonkovidova closed this task as Resolved.Nov 8 2021, 10:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL