Page MenuHomePhabricator
Create Task
Maniphest T294605

Translate master is not compatible with 1.37 (and likely .35/6) VisualEditor
Closed, ResolvedPublic
Actions

Description

Translate master should be backwards compatible but a commit on the master branch is (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/730189) dependant on a commit only in VE master (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/725297).

VE support is based on release branches so the VE changes need to be on all Translate Supported release branches.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemleb-2021.11+9 -7Introduced version check on VisualEditor features
mediawiki/extensions/Translatemleb-2021.11+9 -7Introduced version check on VisualEditor features
mediawiki/extensions/Translatemaster+9 -7Introduced version check on VisualEditor features
mediawiki/extensions/VisualEditorREL1_37+347 -8Handle annotation tags as nodes rather than metaitems.
Customize query in gerrit

Related Objects

Event Timeline

RhinosF1 triaged this task as High priority.Oct 28 2021, 10:07 PM
RhinosF1 created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2021, 10:07 PM
gerritbot added a comment.Oct 28 2021, 10:16 PM

Change 735339 had a related patch set uploaded (by RhinosF1; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/VisualEditor@REL1_37] Handle annotation tags as nodes rather than metaitems.

https://gerrit.wikimedia.org/r/735339

gerritbot added a project: Patch-For-Review.Oct 28 2021, 10:16 PM
RhinosF1 added a comment.Oct 28 2021, 10:22 PM
In T294605#7466897, @gerritbot wrote:

Change 735339 had a related patch set uploaded (by RhinosF1; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/VisualEditor@REL1_37] Handle annotation tags as nodes rather than metaitems.

https://gerrit.wikimedia.org/r/735339

I uploaded a patch although I don't think a simple cherry pick looks easy.

RhinosF1 renamed this task from Translate master is not compatible with 1.37 VisualEditor to Translate master is not compatible with 1.37 (and likely .35/6) VisualEditor.Oct 28 2021, 10:22 PM
RhinosF1 mentioned this in T261181: Make Translate extension compatible with Parsoid.
R4356th added a subscriber: R4356th.Oct 29 2021, 3:02 PM
ihurbain claimed this task.Oct 29 2021, 4:45 PM
ihurbain added a subscriber: ihurbain.

After discussing this issue, it seems the preferred approach would be to condition the loading of the VE features in translate to the existence of the corresponding code in VE. I'll take care of that on Monday.

matmarex added a subscriber: matmarex.Oct 29 2021, 4:54 PM
gerritbot added a comment.Nov 1 2021, 11:57 AM

Change 735958 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@master] Introduced version check on VisualEditor features

https://gerrit.wikimedia.org/r/735958

Reedy moved this task from Blocker to Not a blocker on the MW-1.37-release board.Nov 2 2021, 5:46 PM
gerritbot added a comment.Nov 3 2021, 10:44 PM

Change 735339 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/VisualEditor@REL1_37] Handle annotation tags as nodes rather than metaitems.

Reason:

Looks like we're going to disable the broken feature in Translate on 1.37 (see https://gerrit.wikimedia.org/r/c/735958) rather than backporting it.

https://gerrit.wikimedia.org/r/735339

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Nov 4 2021, 3:41 PM
gerritbot added a comment.Nov 9 2021, 1:59 PM

Change 735958 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Introduced version check on VisualEditor features

https://gerrit.wikimedia.org/r/735958

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 9 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 9 2021, 2:10 PM
matmarex closed this task as Resolved.Nov 9 2021, 2:58 PM
RhinosF1 added a comment.Nov 12 2021, 7:48 AM

Can we get an expidated release of translate or announcement?

It doesn't seem right to wait until the next MLEB release for this.

abi_ mentioned this in T295671: Release MLEB-2021.11.Nov 15 2021, 9:56 AM
abi_ added a subscriber: abi_.Nov 15 2021, 9:59 AM
In T294605#7499556, @RhinosF1 wrote:

Can we get an expidated release of translate or announcement?

It doesn't seem right to wait until the next MLEB release for this.

Created: T295671: Release MLEB-2021.11 - Will try to release it this week.

gerritbot added a comment.Nov 16 2021, 11:03 AM

Change 739135 had a related patch set uploaded (by Abijeet Patro; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@mleb-2021.11] Introduced version check on VisualEditor features

https://gerrit.wikimedia.org/r/739135

gerritbot added a project: Patch-For-Review.Nov 16 2021, 11:03 AM
gerritbot added a comment.Nov 16 2021, 12:01 PM

Change 739135 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@mleb-2021.11] Introduced version check on VisualEditor features

Reason:

Will resubmit

https://gerrit.wikimedia.org/r/739135

gerritbot added a comment.Nov 16 2021, 12:03 PM

Change 739177 had a related patch set uploaded (by Abijeet Patro; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@mleb-2021.11] Introduced version check on VisualEditor features

https://gerrit.wikimedia.org/r/739177

gerritbot added a comment.Nov 16 2021, 1:06 PM

Change 739177 merged by jenkins-bot:

[mediawiki/extensions/Translate@mleb-2021.11] Introduced version check on VisualEditor features

https://gerrit.wikimedia.org/r/739177

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2021, 1:10 PM
abi_ added a project: Language-Team (Language-2021-October-December).Nov 17 2021, 9:41 AM
Mirahamira added a subscriber: Mirahamira.Jan 24 2022, 11:42 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL