Create a log entry when the LogHandler is called
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Niharika
	Oct 29 2021, 5:42 PM

Description

Motivation

Read epic task T292755: Epic: IP Info access for context.

By doing this task, a log entry should be created any time the popup is accessed (the popup can use either LogHandler or RevisionHandler and T294658: Create a log entry when the RevisionHandler is called will handle RevisionHandler)

AC

If the LogHandler should return information about an IP, log it using the job created by T294658: Create a log entry when the RevisionHandler is called

Spec

When a user views the IP Info popup create a log entry
The log entry should capture:
- Who performed the IP information check
- Access level of the information viewed (limited or full)
- Which IP address' information was viewed
- Indicate that the popup was accessed
- Timestamp of the check
Only one log entry should be created if the same user makes multiple checks against the same IP address over a period of 24 hours

Sample log entries:

User:A viewed limited IP Information popup for 1.1.1.1 at October 22, 11:25 UTC
User:B viewed full IP Information popup for 1.2.3.4 at October 28, 00:04 UTC

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/IPInfo	master	+51 -6	Create a log entry when the LogHandler is called

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T285977 IP Info
Resolved	Niharika	T292755 Epic: IP Info access
Resolved	STran	T298955 Return different data from IPInfo api based on context [M]
Resolved	STran	T300825 IPInfo logger should queue a logging job instead of writing directly
Resolved	STran	T294658 Create a log entry when the RevisionHandler is called
Resolved	TThoabala	T294657 Create a log entry when the LogHandler is called
Resolved	phuedx	T294680 IP Info: Create a logger function to be used in both the popup and accordion presenters [M]

Event Timeline

Niharika triaged this task as Medium priority.Oct 29 2021, 5:42 PM

Niharika created this task.

Niharika updated the task description. (Show Details)

Would these log lines continue to show an IP address in a post-IP masking world? Or would they be retroactively updated?

In T294657#7469468, @STran wrote:

Would these log lines continue to show an IP address in a post-IP masking world? Or would they be retroactively updated?

I think this is where we can leverage MediaWiki's on-wiki logging infrastructure:

Log lines (actions) are formatted by a formatter (handler) – which formatter formats which log line is governed by $wgLogActionsHandlers. We're going to need to create at least one formatter for the log lines that IPInfo produces so we could bake in the idea that the target IP can be formatted as masked (but do nothing about it for now) with near-zero cost.

phuedx removed a project: Epic.Nov 2 2021, 3:14 PM

Change 736267 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/IPInfo@master] WIP: Add IPInfo log to Special:Log

https://gerrit.wikimedia.org/r/736267

gerritbot added a project: Patch-For-Review.Nov 2 2021, 3:20 PM

phuedx renamed this task from IP Info: Create a log entry when the IP Info popup is viewed to Create a log entry when the popup is viewed.Nov 2 2021, 3:39 PM

phuedx added a project: Anti-Harassment.

phuedx updated the task description. (Show Details)

phuedx moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

phuedx added a subtask: T294680: IP Info: Create a logger function to be used in both the popup and accordion presenters [M].Nov 4 2021, 9:47 AM

phuedx mentioned this in T295017: Display ipinfo log lines on Special:Log.Nov 4 2021, 10:21 AM

phuedx updated the task description. (Show Details)Nov 4 2021, 10:42 AM

phuedx removed a project: Patch-For-Review.

phuedx mentioned this in T294680: IP Info: Create a logger function to be used in both the popup and accordion presenters [M].Dec 10 2021, 1:53 PM

ARamirez_WMF renamed this task from Create a log entry when the popup is viewed to Create a log entry when the popup is viewed [S].Dec 14 2021, 5:17 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Dec 16 2021, 5:00 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Dec 22 2021, 5:31 PM

• Prtksxna mentioned this in T294658: Create a log entry when the RevisionHandler is called.Jan 3 2022, 8:59 AM

STran added a parent task: T298955: Return different data from IPInfo api based on context [M].Jan 11 2022, 11:31 AM

Tchanders moved this task from Blocked/Stalled 🚧 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.Jan 18 2022, 5:23 PM

Tchanders mentioned this in T300135: Create a LoggerFactory service for IPInfo.Jan 26 2022, 1:06 PM

STran mentioned this in T300825: IPInfo logger should queue a logging job instead of writing directly.Feb 3 2022, 5:24 AM

STran added a parent task: T300825: IPInfo logger should queue a logging job instead of writing directly.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Feb 4 2022, 12:37 AM

ARamirez_WMF renamed this task from Create a log entry when the popup is viewed [S] to Create a log entry when the popup is viewed.Feb 8 2022, 5:00 PM

ARamirez_WMF set the point value for this task to 2.

Tchanders moved this task from Blocked/Stalled 🚧 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.Feb 9 2022, 3:55 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Feb 9 2022, 4:00 PM

STran renamed this task from Create a log entry when the popup is viewed to Create a log entry when the LogHandler is called.Feb 10 2022, 2:19 PM

STran updated the task description. (Show Details)

STran added a parent task: T294658: Create a log entry when the RevisionHandler is called.

Tchanders moved this task from Blocked/Stalled 🚧 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.Feb 15 2022, 2:49 PM

TThoabala claimed this task.Feb 15 2022, 3:02 PM

TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Niharika closed subtask T294680: IP Info: Create a logger function to be used in both the popup and accordion presenters [M] as Resolved.Feb 17 2022, 1:48 AM

Change 763393 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Create a log entry when the LogHandler is called

https://gerrit.wikimedia.org/r/763393

gerritbot added a project: Patch-For-Review.Feb 17 2022, 4:11 AM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 2: The Pork Pie); removed Patch-For-Review, Anti-Harassment (The Letter Song), IP Info.Feb 17 2022, 8:47 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 17 2022, 8:51 PM

TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 18 2022, 11:04 AM

Change 763393 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Create a log entry when the LogHandler is called

https://gerrit.wikimedia.org/r/763393

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 22 2022, 11:00 AM

This is another one that could be tested after or during T295017: Display ipinfo log lines on Special:Log

Verified LogHandler and RevisionHandler events is recorded in the log table below:

"Who performed the IP information check" is the actor_id field

imaigwilo moved this task from QA/Testing 🐞 to Done Q3 2022 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 23 2022, 4:11 AM

imaigwilo moved this task from Done Q3 2022 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 23 2022, 4:44 AM

imaigwilo moved this task from QA/Testing 🐞 to Done Q3 2022 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 25 2022, 9:39 PM

Niharika closed this task as Resolved.Mar 1 2022, 7:20 AM

	F34962593: Screen Shot 2022-02-22 at 10.58.00 PM.png
	Feb 23 2022, 4:00 AM

Create a log entry when the LogHandler is calledClosed, ResolvedPublic2 Estimated Story PointsActions