Error: Call to a member function warning() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.38.0-wmf.6
reqId: 73cd0e50-f2e3-4d9e-99de-fee2daf825a9
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function warning() on null

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/Mentorship/QuitMentorship.php(134)
#0 /srv/mediawiki/php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/Mentorship/ReassignMenteesJob.php(53): GrowthExperiments\Mentorship\QuitMentorship->doReassignMentees(string)
#1 /srv/mediawiki/php-1.38.0-wmf.6/extensions/EventBus/includes/JobExecutor.php(79): GrowthExperiments\Mentorship\ReassignMenteesJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#3 {main}

Impact

only two exceptions are logged; both are on ckbwiki
I checked ckbwiki Homepage - the mentorship module is not present.

Details

Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/GrowthExperiments	wmf/1.38.0-wmf.6	+6 -1	QuitMentorship: Pass a logger
	mediawiki/extensions/GrowthExperiments	master	+6 -1	QuitMentorship: Pass a logger

Customize query in gerrit

Related Objects

Mentioned Here: rEGRE4671528977db: QuitMentorship: Pass a logger

Event Timeline

Etonkovidova created this task.Oct 29 2021, 8:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2021, 8:41 PM

Change 735699 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] QuitMentorship: Pass a logger

https://gerrit.wikimedia.org/r/735699

gerritbot added a project: Patch-For-Review.Oct 29 2021, 9:47 PM

This is from the mentor dashboard, updating tags.

The immediate cause is that I forgot to pass a logger to QuitMentorship -- a fixing patch uploaded. However, I'm wondering how it was even executed at ckbwiki, a wiki with mentorship disabled?

In T294665#7469046, @Urbanecm_WMF wrote:

This is from the mentor dashboard, updating tags.

The immediate cause is that I forgot to pass a logger to QuitMentorship -- a fixing patch uploaded. However, I'm wondering how it was even executed at ckbwiki, a wiki with mentorship disabled?

Apparently, for some reason, we decided to enable mentor dashboard there, which comes with this special page (although it's supposed to be hard to find it, without link from mentor dashboard).

@Trizek-WMF I'm confused by the combination of mentor dashboard enabled at ckb.wikipedia, while https://ckb.wikipedia.org/wiki/%D8%AA%D8%A7%DB%8C%D8%A8%DB%95%D8%AA:EditGrowthConfig says "Are mentorship features enabled?" ===> "No". Can you please figure out why ckbwiki has mentorship disabled?

Urbanecm_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Oct 29 2021, 11:04 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Urbanecm_WMF triaged this task as Medium priority.Oct 30 2021, 8:57 PM

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.

Change 735699 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] QuitMentorship: Pass a logger

https://gerrit.wikimedia.org/r/735699

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 1 2021, 11:00 AM

Change 735641 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.6] QuitMentorship: Pass a logger

https://gerrit.wikimedia.org/r/735641

gerritbot added a project: Patch-For-Review.Nov 1 2021, 11:21 AM

Change 735641 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.6] QuitMentorship: Pass a logger

https://gerrit.wikimedia.org/r/735641

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 1 2021, 12:00 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-01T12:07:29Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/Mentorship/QuitMentorshipFactory.php: 4671528977db15b4e287d50980a684223ab6f611: QuitMentorship: Pass a logger (T294665; 1/2) (duration: 00m 56s)

Mentioned in SAL (#wikimedia-operations) [2021-11-01T12:08:24Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/Mentorship/QuitMentorship.php: 4671528977db15b4e287d50980a684223ab6f611: QuitMentorship: Pass a logger (T294665; 2/2) (duration: 00m 55s)

Urbanecm_WMF closed this task as Resolved.Nov 1 2021, 12:41 PM

In T294665#7469184, @Urbanecm_WMF wrote:

@Trizek-WMF I'm confused by the combination of mentor dashboard enabled at ckb.wikipedia, while https://ckb.wikipedia.org/wiki/%D8%AA%D8%A7%DB%8C%D8%A8%DB%95%D8%AA:EditGrowthConfig says "Are mentorship features enabled?" ===> "No". Can you please figure out why ckbwiki has mentorship disabled?

Mentoring was not turned on when I checked. It is now active.

Krinkle moved this task from Untriaged to Nov 2021 on the Wikimedia-production-error board.Dec 3 2021, 1:45 PM

Error: Call to a member function warning() on nullClosed, ResolvedPublicPRODUCTION ERRORActions