Page MenuHomePhabricator
Create Task
Maniphest T294672

Image instrumentation: edit summary
Closed, ResolvedPublic
Actions

Description

Corresponding task from "add a link": T278118: Instrumentation: Edit summary
Associated feature: T292092: Add an image: overlay onboarding

Once the user is on the edit summary screen, we want to record these actions:

  • Impression for the screen, including whether they accepted or rejected the image (this indicates the state of the screen).
  • Selecting the "back" arrow to return to the caption step.
  • Selecting the "review your changes" button.
  • Selecting the Publish/Submit button.
  • If the user had accepted the image, the publish event should include the number of characters in the caption.

Details

SubjectRepoBranchLines +/-
Add an image: edit summary instrumentationmediawiki/extensions/GrowthExperimentsmaster+41 -11
Add an image: update schema for editsummary_dialogschemas/event/secondarymaster+449 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Oct 29 2021, 11:35 PM
MMiller_WMF triaged this task as High priority.Oct 29 2021, 11:47 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph claimed this task.Nov 4 2021, 10:08 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 5 2021, 9:34 PM

Change 737135 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[schemas/event/secondary@master] Add an image: update schema for editsummary_dialog

https://gerrit.wikimedia.org/r/737135

gerritbot added a project: Patch-For-Review.Nov 5 2021, 9:34 PM

Change 737136 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: edit summary instrumentation

https://gerrit.wikimedia.org/r/737136

• mewoph added a comment.Nov 5 2021, 9:36 PM

Sample events:

Impression (rejected)

event: {
  "action": "impression",
  "action_data": "acceptance_state=rejected",
  "is_mobile": true,
  "active_interface": "editsummary_dialog",
  "newcomer_task_token": "739f59605020bd94e1ec",
  "page_id": 1789,
  "page_title": "Edward Edwards (Royal Navy officer)",
  "homepage_pageview_token": "lf8lidfquuol581137kh7a8h70r996nr",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "192.168.86.22"
  },
  "dt": "2021-11-05T21:26:49.550Z"
}

Impression (accepted)

event: {
  "action": "impression",
  "action_data": "acceptance_state=accepted;caption_length=15",
  "is_mobile": true,
  "active_interface": "editsummary_dialog",
  "newcomer_task_token": "8dee0874d6df4732f7a8",
  "page_id": 1789,
  "page_title": "Edward Edwards (Royal Navy officer)",
  "homepage_pageview_token": "8pjob3ev3s5bha5t8b3tqtrq4usq8v91",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "192.168.86.22"
  },
  "dt": "2021-11-05T21:28:20.236Z"
}

Back

event: {
  "action": "close",
  "action_data": "acceptance_state=accepted;caption_length=15",
  "is_mobile": true,
  "active_interface": "editsummary_dialog",
  "newcomer_task_token": "8dee0874d6df4732f7a8",
  "page_id": 1789,
  "page_title": "Edward Edwards (Royal Navy officer)",
  "homepage_pageview_token": "8pjob3ev3s5bha5t8b3tqtrq4usq8v91",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "192.168.86.22"
  },
  "dt": "2021-11-05T21:28:40.204Z"
}

Review

event: {
  "action": "editsummary_review",
  "action_data": "acceptance_state=accepted;caption_length=15",
  "is_mobile": true,
  "active_interface": "editsummary_dialog",
  "newcomer_task_token": "8dee0874d6df4732f7a8",
  "page_id": 1789,
  "page_title": "Edward Edwards (Royal Navy officer)",
  "homepage_pageview_token": "8pjob3ev3s5bha5t8b3tqtrq4usq8v91",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "192.168.86.22"
  },
  "dt": "2021-11-05T21:29:04.942Z"
}

Save (rejected)

event: {
  "action": "editsummary_save",
  "action_data": "acceptance_state=rejected",
  "is_mobile": true,
  "active_interface": "editsummary_dialog",
  "newcomer_task_token": "739f59605020bd94e1ec",
  "page_id": 1789,
  "page_title": "Edward Edwards (Royal Navy officer)",
  "homepage_pageview_token": "lf8lidfquuol581137kh7a8h70r996nr",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "192.168.86.22"
  },
  "dt": "2021-11-05T21:27:21.446Z"
}

Save (accepted)

event: {
  "action": "editsummary_save",
  "action_data": "acceptance_state=accepted;caption_length=15",
  "is_mobile": true,
  "active_interface": "editsummary_dialog",
  "newcomer_task_token": "8dee0874d6df4732f7a8",
  "page_id": 1789,
  "page_title": "Edward Edwards (Royal Navy officer)",
  "homepage_pageview_token": "8pjob3ev3s5bha5t8b3tqtrq4usq8v91",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "192.168.86.22"
  },
  "dt": "2021-11-05T21:29:24.349Z"
}
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 5 2021, 9:36 PM
gerritbot added a comment.Nov 8 2021, 10:12 AM

Change 737135 merged by jenkins-bot:

[schemas/event/secondary@master] Add an image: update schema for editsummary_dialog

https://gerrit.wikimedia.org/r/737135

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 8 2021, 8:09 PM
gerritbot added a comment.Nov 8 2021, 8:30 PM

Change 737136 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: edit summary instrumentation

https://gerrit.wikimedia.org/r/737136

Wittylama removed a subscriber: Wittylama.Nov 8 2021, 8:38 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 8 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 8 2021, 9:10 PM
QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 5:37 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 23 2021, 10:24 PM

Checked - all looks according to the specs and the details are matched https://phabricator.wikimedia.org/T294672#7486707

Note: If a user selects Minerva skin on Desktop, Add image will work. The schema would record is_mobile: false.

{action: 'impression', action_data: 'filename=Picto_infobox_reptile.png;recommendation_…ns=1;rejection_reasons=;acceptance_state=accepted', is_mobile: false, newcomer_task_token: '4e2013a2f0aafbd9950d', page_id: 265138, …}
$schema: "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.1.2"
action: "impression"
action_data: "filename=Picto_infobox_reptile.png;recommendation_source=wikipedia;recommendation_source_projects=kowiki;series_number=1;total_suggestions=1;rejection_reasons=;acceptance_state=accepted"
active_interface: "caption_entry"
dt: "2021-11-23T22:21:03.733Z"
homepage_pageview_token: "o6klsm2h2tkuttijl4dfjcu8ptanciq6"
is_mobile: false
meta: {stream: 'mediawiki.structured_task.article.image_suggestion_interaction', domain: 'en.wikipedia.beta.wmflabs.org'}
newcomer_task_token: "4e2013a2f0aafbd9950d"
page_id: 265138
page_title: "Hudson's Oldfield mouse"
nettrom_WMF closed this task as Resolved.Jan 6 2022, 11:01 PM

We've used data for this extensively for T297138 and T296364. All the data I've seen made sense (e.g. users reaching the edit summary, reviewing, going back, etc…) As far as I can tell, this can be resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL