hreflang Tags' alternate URLs are not fully-qualified
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	VulpesVulpes825
	Nov 1 2021, 1:06 AM

Description

List of steps to reproduce:

Check the heading of HTML code for any page which its content language has variants (For example, homepage of Chinese Wikipedia)

What happens?:
hreflang Tags' alternate URLs are not fully-qualified
<link rel="alternate" hreflang="zh" href="/zh/Wikipedia:%E9%A6%96%E9%A1%B5">

What should have happened instead?:
hreflang Tags' alternate URLs should be fully-qualified
<link rel="alternate" hreflang="zh" href="https://zh.wikipedia.org/zh/Wikipedia:%E9%A6%96%E9%A1%B5">

Why it matters:

Search Engine like Google requires the hreflang tag to be fully-qualified. See here for details.
If you use the hreflang Tags testing tool, the hreflang on Chinese Wikipedia are not following the standard, making the tags in the HTML codes useless.

QA Results - Beta

AC	Status	Details
1	✅	T294716#8559537

QA Results - Prod

AC	Status	Details
1	✅	T294716#8567007

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make sure hreflang Tags' alternate URLs are fully-qualified	mediawiki/core	master	+25 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdlrobson	T305540 Google search traffic sending users to the wrong Chinese language versions of Wikipedia
Resolved	BUG REPORT	ovasileva	T294716 hreflang Tags' alternate URLs are not fully-qualified
Resolved	BUG REPORT	Jdlrobson	T328209 Alternate URLs should be desktop-mobile-site-aware

Event Timeline

VulpesVulpes825 created this task.Nov 1 2021, 1:06 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptNov 1 2021, 1:06 AM

Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript

Change 735753 had a related patch set uploaded (by VulpesVulpes825; author: Junyin Chen):

[mediawiki/core@master] Make sure hreflang Tags' alternate URLs are fully-qualified

https://gerrit.wikimedia.org/r/735753

gerritbot added a project: Patch-For-Review.Nov 1 2021, 1:39 AM

Reedy added projects: MW-1.35-release, MW-1.36-release, MW-1.37-release.Nov 1 2021, 2:29 AM

VulpesVulpes825 claimed this task.Nov 1 2021, 5:26 AM

VulpesVulpes825 moved this task from Backlog to MediaWiki core on the Chinese-Sites board.Nov 1 2021, 8:58 PM

(moving to not a blocker for now since it's been a bug for a long time, but it would be nice to have)

• dpifke edited projects, added MediaWiki-General; removed Performance-Team, MediaWiki-ResourceLoader.Nov 8 2021, 8:02 PM

Untagging, not related to ResourceLoader.

Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.Dec 2 2021, 5:04 AM

Krinkle moved this task from Blocker to Not a blocker on the MW-1.36-release board.Mar 23 2022, 8:43 PM

Func mentioned this in T305367: Google search traffic sending users to the wrong Chinese language versions of Wikipedia.Apr 4 2022, 3:32 PM

Nicholas_Perry mentioned this in T305540: Google search traffic sending users to the wrong Chinese language versions of Wikipedia.Apr 6 2022, 10:43 AM

Nicholas_Perry added a parent task: T305540: Google search traffic sending users to the wrong Chinese language versions of Wikipedia.Apr 12 2022, 10:42 AM

Reedy removed a project: MW-1.36-release.May 18 2022, 7:06 PM

Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptMay 18 2022, 7:06 PM

YLJ subscribed.Jun 5 2022, 2:17 PM

Hi folks, this has been staled for a while. Any chance we can push this forward a bit?

I'm daily wiki users and a programmer from Taiwan. Would love to see SEO of wiki chinese sites work smoothly. Happy to help out!

YLJ mentioned this in T108443: Google doesn't honor canonical URLs of zh.wiki.Jun 5 2022, 3:16 PM

Ericliu1912 unsubscribed.Jun 29 2022, 1:34 PM

@YLJ: Anyone is welcome to amend the proposed patch in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/735753/ - thanks in advance!

In T294716#8039307, @Aklapper wrote:

@YLJ: Anyone is welcome to amend the proposed patch in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/735753/ - thanks in advance!

I'd like to help, but I'm not a member of the Trusted-Contributors group on Gerrit, would you mind adding me to the group?

@Func: added with https://gerrit.wikimedia.org/r/admin/groups/2021f25e7515187a81d51f8fe14dd6f25617cce0,audit-log

1.37.x is now EOL.

TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:35 PM

Reedy removed a project: MW-1.35-release.Jan 9 2023, 12:18 AM

Func mentioned this in T326831: Language alternative variant URLS should be absolute not relative.Jan 12 2023, 5:37 PM

This has been flagged as something really important to fix. Web team will make sure this gets done.

Jdlrobson edited projects, added Web-Team FY2022-23 Q3 Sprint 1; removed Web-Team-Backlog-Archived.Jan 12 2023, 5:43 PM

The patch looks fine to me, but I've asked for clarity on the ticket if anything is blocking it with an aim to merge it Monday.

ovasileva triaged this task as High priority.Jan 12 2023, 6:08 PM

Winston_Sung subscribed.Jan 13 2023, 4:24 AM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/32d87a158c/wiki/Main Page

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/32d87a158c/w/~~

Xiplus subscribed.Jan 13 2023, 8:48 AM

Jdlrobson moved this task from Code Review to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 17 2023, 7:27 PM

Change 735753 merged by jenkins-bot:

[mediawiki/core@master] Make sure hreflang Tags' alternate URLs are fully-qualified

https://gerrit.wikimedia.org/r/735753

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 17 2023, 8:00 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jan 18 2023, 10:37 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2023, 11:30 PM

Change 879579 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Fix the behavior for language variants for meta canonical and alternate

https://gerrit.wikimedia.org/r/879579

gerritbot added a project: Patch-For-Review.Jan 25 2023, 10:01 AM

@Jdlrobson is there a page on beta were this can be verified?

In T294716#8558315, @Edtadros wrote:

Is there a page on beta were this can be verified?

It should already be available on beta Wikipedia-zh:

https://zh.wikipedia.beta.wmflabs.org/wiki/

In T294716#8558358, @Winston_Sung wrote:

In T294716#8558315, @Edtadros wrote:

Is there a page on beta were this can be verified?

It should already be available on beta Wikipedia-zh:

https://zh.wikipedia.beta.wmflabs.org/wiki/

Thanks!

Edtadros claimed this task.Jan 26 2023, 1:20 AM

Test Result - Beta

Status: ✅ PASS
Environment: zhbeta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

List of steps to reproduce:

Check the heading of HTML code for any page which its content language has variants (For example, homepage of Chinese Wikipedia)
✅ AC1: hreflang Tags' alternate URLs should be fully-qualified

Screenshot 2023-01-25 at 5.32.26 PM.png (892×1 px, 460 KB)

Test Result - Prod

Status: ✅ PASS
Environment: zhwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

List of steps to reproduce:

Check the heading of HTML code for any page which its content language has variants (For example, homepage of Chinese Wikipedia)
✅ AC1: hreflang Tags' alternate URLs should be fully-qualified

Screenshot 2023-01-28 at 4.56.09 PM.png (1×1 px, 656 KB)

Edtadros updated the task description. (Show Details)Jan 29 2023, 12:59 AM

Winston_Sung added a subtask: T328209: Alternate URLs should be desktop-mobile-site-aware.Jan 29 2023, 9:20 AM

Winston_Sung removed a project: Patch-For-Review.Jan 31 2023, 4:14 AM

Jdlrobson added a project: Web-Team-Backlog-Archived.Feb 3 2023, 4:57 PM

Jdlrobson moved this task from Incoming to Sprint 1 (non-milestone) on the Web-Team-Backlog-Archived board.Feb 3 2023, 4:59 PM

On :https://zh.m.wikipedia.org/zh/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC the hreflang Tags' alternate URLs previously looked like:

<link rel="alternate" hreflang="zh" href="/zh/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans" href="/zh-hans/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant" href="/zh-hant/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans-CN" href="/zh-cn/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant-HK" href="/zh-hk/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant-MO" href="/zh-mo/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans-MY" href="/zh-my/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans-SG" href="/zh-sg/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant-TW" href="/zh-tw/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>

They now look like:

<link rel="alternate" hreflang="zh" href="https://zh.wikipedia.org/zh/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans" href="https://zh.wikipedia.org/zh-hans/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant" href="https://zh.wikipedia.org/zh-hant/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans-CN" href="https://zh.wikipedia.org/zh-cn/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant-HK" href="https://zh.wikipedia.org/zh-hk/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant-MO" href="https://zh.wikipedia.org/zh-mo/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans-MY" href="https://zh.wikipedia.org/zh-my/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hans-SG" href="https://zh.wikipedia.org/zh-sg/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="zh-Hant-TW" href="https://zh.wikipedia.org/zh-tw/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
<link rel="alternate" hreflang="x-default" href="https://zh.wikipedia.org/wiki/%E6%9F%A5%E7%90%86%C2%B7%E8%8A%92%E6%A0%BC"/>
`

I'm going to follow up to find out how important it is to do T328209 (include the mobile domain) and T54429 (canonical URLs do not include the language variant).

Stang moved this task from MediaWiki core to Closed on the Chinese-Sites board.Feb 6 2023, 10:31 PM

Winston_Sung moved this task from Untriaged to Multilanguage & Language variants on the I18n board.Feb 7 2023, 6:16 AM

Stang unsubscribed.Feb 10 2023, 10:33 PM

Jdlrobson changed the status of subtask T328209: Alternate URLs should be desktop-mobile-site-aware from Open to Stalled.Feb 22 2023, 8:01 PM

Jdlrobson closed subtask T328209: Alternate URLs should be desktop-mobile-site-aware as Resolved.Apr 18 2023, 4:57 PM

	F36544385: Screenshot 2023-01-28 at 4.56.09 PM.png
	Jan 29 2023, 12:57 AM

	F36511068: Screenshot 2023-01-25 at 5.32.26 PM.png
	Jan 26 2023, 1:33 AM

hreflang Tags' alternate URLs are not fully-qualifiedClosed, ResolvedPublicBUG REPORTActions

Description

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

hreflang Tags' alternate URLs are not fully-qualified
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...