Page MenuHomePhabricator

Highlight the preference when hovering on "Set a local exception"
Closed, ResolvedPublic1 Estimated Story Points

Description

When hovering over the "Set a local exception for this global preference" checkboxes, the associated preference used to be highlighted with a background color (of eaecf0). This is based on a table layout of the preferences form, which was dropped in r461183 (in 2018).

The old design can be seen in https://commons.wikimedia.org/wiki/File:Screenshot_of_MediaWiki_GlobalPreferences_local_exception.png

Should the highlighting be fixed, or removed entirely?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hi @Samwilson, I haven't seen this design before, either on the design style guide so I believe we can remove it :)

Change 737540 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/GlobalPreferences@master] Remove old and unused CSS and hover-state for local prefs

https://gerrit.wikimedia.org/r/737540

Change 737540 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Remove old and unused code and hover-state for local prefs

https://gerrit.wikimedia.org/r/737540

The old code has been removed now, and nothing should've changed in the UI.

dom_walden moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-13) board.
dom_walden added a subscriber: dom_walden.

The old code has been removed now, and nothing should've changed in the UI.

Thanks. I haven't noticed any differences when I have been testing Special:Preferences for other tickets.

I don't think there is anything for the PM to see or decide here, so moving straight to Done.