WikiLambda: Add ZObject::getSerialized() unit tests
Open, In Progress, MediumPublic
Actions

Assigned To

Authored By

	gengh
	Nov 2 2021, 12:06 PM

Description

ZObject.php and all its inheriting classes (all classes in the ZObjects directory) have a getSerialized() method that transforms a tree of ZObject instances into the JSON representation of that ZObject in canonical or normal form.

Tests for all ZObject classes should be added to check that the instances are serialized properly.

Current code: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/includes/ZObjects/ZObject.php#243 plus that method in sub-classes where over-ridden.
Current coverage report example: https://doc.wikimedia.org/cover-extensions/WikiLambda/includes/ZObjects/ZString.php.html#64

Details

	Subject	Repo	Branch	Lines +/-
	Add ZObject::getSerialized() unit tests - WIP for comment	mediawiki/extensions/WikiLambda	master	+1 K -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T302513 Increase code coverage of all WikiLambda PHP code to at least <THRESHOLD TBD>
Open	None	T302599 Increase code coverage of all WikiLambda PHP ZObjects code to 100% of lines and methods (or marked as ignored if structural)
In Progress	William_Avery	T294826 WikiLambda: Add ZObject::getSerialized() unit tests
Open	None	T342696 Align WikiLambda's PHP code for canonicalise/normalise with function-schemata's JS code, so they don't disagree

Event Timeline

gengh created this task.Nov 2 2021, 12:06 PM

DVrandecic moved this task from To triage to To triage: Un-phased work on the Abstract Wikipedia team board.Nov 3 2021, 4:15 PM

gengh renamed this task from Add ZObject::serialize() tests in WikiLambda to WikiLambda: Add ZObject::getSerialized() unit tests.Nov 30 2021, 2:19 PM

gengh added a project: good first task.

gengh updated the task description. (Show Details)

DVrandecic moved this task from To triage: Un-phased work to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:40 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

gengh claimed this task.Dec 3 2021, 2:27 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:54 PM

Jdforrester-WMF added a parent task: T302599: Increase code coverage of all WikiLambda PHP ZObjects code to 100% of lines and methods (or marked as ignored if structural).Feb 25 2022, 4:02 PM

gengh removed gengh as the assignee of this task.Mar 17 2022, 9:11 AM

Jdforrester-WMF added a project: good first task.May 17 2022, 1:45 PM

Jdforrester-WMF updated the task description. (Show Details)

Quiddity added a project: Wikimedia-Hackathon-2022.May 20 2022, 4:39 AM

Quiddity moved this task from Backlog to Projects for Newcomers! on the Wikimedia-Hackathon-2022 board.

Quiddity subscribed.May 20 2022, 9:27 PM

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:47 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:30 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:01 AM

SDunlap mentioned this in T321934: E2E test for CUJ 3: Edit a function definition.Mar 27 2023, 6:30 PM

William_Avery claimed this task.May 3 2023, 6:53 PM

Change 936308 had a related patch set uploaded (by William Avery; author: William Avery):

[mediawiki/extensions/WikiLambda@master] Commit of WIP for comment

https://gerrit.wikimedia.org/r/936308

gerritbot added a project: Patch-For-Review.Jul 7 2023, 4:47 PM

I have evidently messed up and overwritten some changes of T332865 regarding self versus $tthis

@William_Avery: Hi, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 how to fix and upload a new pacthset.

@Aklapper Thank you for your help
Tests are currently failing in ZObjectTest.php because
$testObject->getSerialized( $testObject::FORM_NORMAL )
is returning an object of type stdClass rather than a string.