Page MenuHomePhabricator
Create Task
Maniphest T294826

WikiLambda: Add ZObject::getSerialized() unit tests
Closed, ResolvedPublic
Actions

Description

ZObject.php and all its inheriting classes (all classes in the ZObjects directory) have a getSerialized() method that transforms a tree of ZObject instances into the JSON representation of that ZObject in canonical or normal form.

Tests for all ZObject classes should be added to check that the instances are serialized properly.

Current code: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/includes/ZObjects/ZObject.php#243 plus that method in sub-classes where over-ridden.
Current coverage report example: https://doc.wikimedia.org/cover-extensions/WikiLambda/includes/ZObjects/ZString.php.html#64

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add ZObject::getSerialized() unit tests - WIP for commentWilliam Averymediawiki/extensions/WikiLambdamaster+1 K -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Nov 2 2021, 12:06 PM
DVrandecic moved this task from To Triage to To triage: Un-phased work on the Abstract Wikipedia team board.Nov 3 2021, 4:15 PM
gengh renamed this task from Add ZObject::serialize() tests in WikiLambda to WikiLambda: Add ZObject::getSerialized() unit tests.Nov 30 2021, 2:19 PM
gengh added a project: good first task.
gengh updated the task description. (Show Details)
DVrandecic moved this task from To triage: Un-phased work to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:40 PM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase κ – Clean-up); removed: Abstract Wikipedia team.
gengh claimed this task.Dec 3 2021, 2:27 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia Fix-It tasks; removed: good first task.Jan 18 2022, 7:54 PM
Jdforrester-WMF added a parent task: T302599: Increase code coverage of all WikiLambda PHP ZObjects code to 100% of lines and methods (or marked as ignored if structural).Feb 25 2022, 4:02 PM
gengh removed gengh as the assignee of this task.Mar 17 2022, 9:11 AM
Jdforrester-WMF added a project: good first task.May 17 2022, 1:45 PM
Jdforrester-WMF updated the task description. (Show Details)
Quiddity added a project: Wikimedia-Hackathon-2022.May 20 2022, 4:39 AM
Quiddity moved this task from Backlog to Projects for Newcomers! on the Wikimedia-Hackathon-2022 board.
Quiddity subscribed.May 20 2022, 9:27 PM
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:47 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:30 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:01 AM
• SDunlap mentioned this in T321934: E2E test for CUJ 3: Edit a function definition.Mar 27 2023, 6:30 PM
William_Avery claimed this task.May 3 2023, 6:53 PM
gerritbot added a comment.Jul 7 2023, 4:47 PM

Change 936308 had a related patch set uploaded (by William Avery; author: William Avery):

[mediawiki/extensions/WikiLambda@master] Commit of WIP for comment

https://gerrit.wikimedia.org/r/936308

gerritbot added a project: Patch-For-Review.Jul 7 2023, 4:47 PM
William_Avery added a comment.Jul 7 2023, 5:09 PM

I have evidently messed up and overwritten some changes of T332865 regarding self versus $tthis

Aklapper subscribed.Jul 9 2023, 12:02 PM

@William_Avery: Hi, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 how to fix and upload a new pacthset.

William_Avery added a comment.Jul 10 2023, 12:47 PM

@Aklapper Thank you for your help
Tests are currently failing in ZObjectTest.php because
$testObject->getSerialized( $testObject::FORM_NORMAL )
is returning an object of type stdClass rather than a string.

• SDunlap subscribed.Jul 10 2023, 9:02 PM

I've responded to the patch in gerrit.

Jdforrester-WMF mentioned this in T342696: Align WikiLambda's PHP code for canonicalise/normalise with function-schemata's JS code, so they don't disagree.Jul 25 2023, 8:11 PM
Jdforrester-WMF changed the status of subtask T342696: Align WikiLambda's PHP code for canonicalise/normalise with function-schemata's JS code, so they don't disagree from Open to In Progress.Jul 31 2023, 3:09 PM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 26 2023, 4:51 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF changed the status of subtask T342696: Align WikiLambda's PHP code for canonicalise/normalise with function-schemata's JS code, so they don't disagree from In Progress to Open.Jan 22 2024, 8:08 PM
Jdforrester-WMF moved this task from In Progress to Backlog on the Abstract Wikipedia team board.Apr 29 2024, 6:03 PM
Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.Dec 11 2024, 8:30 PM
Aklapper changed the task status from In Progress to Open.Apr 11 2025, 10:15 PM

Resetting task status from "In Progress" to "Open" as this task has been "in progress" for more than one and a half years (see T380300).

Quiddity unsubscribed.Apr 11 2025, 10:20 PM
Jdforrester-WMF changed the task status from Open to In Progress.Apr 17 2025, 4:10 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q4 (Apr–Jun)); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
Jdforrester-WMF closed subtask T342696: Align WikiLambda's PHP code for canonicalise/normalise with function-schemata's JS code, so they don't disagree as Invalid.
gerritbot added a comment.Apr 17 2025, 4:17 PM

Change #936308 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add ZObject::getSerialized() unit tests - WIP for comment

https://gerrit.wikimedia.org/r/936308

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2025, 4:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 17 2025, 5:00 PM
DSantamaria subscribed.May 12 2025, 4:58 PM

@gengh, could you please take a look at this and verify if it is solved?

gengh closed this task as Resolved.May 14 2025, 9:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits