Page MenuHomePhabricator

block log entry duration message is broken in RTL wikis
Closed, ResolvedPublic

Description

I recently noted that on RTL Wikipedia (such as Persian Wikipedia and Arabic Wikipedia), the "duration" message for block log entries is rotated and the order of words is not correct.

Example:

http://fa.wikipedia.org/w/index.php?title=%D9%88%DB%8C%DA%98%D9%87%3A%D8%B3%DB%8C%D8%A7%D9%87%D9%87%E2%80%8C%D9%87%D8%A7&type=block&user=Behzad.Modares&page=%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1%3A94.182.71.175&year=&month=-1&tagfilter=

It reads:

Behzad.Modares (بحث | مشارکت‌ها | بسته شود) «94.182.71.175 (بحث)» را ۱ روز بست

However, instead of reading as "1 days" (in Persian) it is read as "days 1". This is because in the HTML code, the duration is surrounded by an HTML tag:

<span class="blockExpiry" dir="ltr" title="1 day">

Which has the dir value hardcoded. This breaks RTL layout and should be reverted. Such modifications should always take place at CSS level.


Version: unspecified
Severity: enhancement

Details

Reference
bz27485

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:22 PM
bzimport set Reference to bz27485.
bzimport added a subscriber: Unknown Object (MLST).
Huji created this task.Feb 17 2011, 3:24 AM

That's because you yourself requested it in bug 25839.

Huji added a comment.Feb 17 2011, 1:30 PM

Well, I never asked this to be added hardcoded; I asked this to be added through CSS.

Also, I relied on Roan's comment there, that after this change the Arabic text for "1 week" was still shown in the correct order (I didn't check it myself).

The LTR rendering is still required when the block expiry is a timestamp. However, if the expiry is a localized text, it shouldn't be rendered as LTR.

Resolving dupe of 25839 so that we can all concentrate on that bug.

  • This bug has been marked as a duplicate of bug 25839 ***
Restricted Application added a project: I18n. · View Herald TranscriptJun 2 2015, 2:20 PM