Page MenuHomePhabricator

Sticky header: full feature design review
Closed, ResolvedPublic

Description

Background

This task will encompass the final pre-deployment design review of the sticky header feature.

Review in production with URL parameter: ?vectorstickyheader=1, ?vectorstickyheaderedit=0

Acceptance criteria

  • Perform design review of the sticky header feature and note any bugs and remaining work to be done

Event Timeline

Search
Page title
Language switcher
  • When I click the language switcher the page scrolls down by 1-2px. This should not happen.
    • no task needed
  • When the language menu is open the language button has a dark gray background. This is incorrect. It should match the user menu:
Screen Shot 2021-11-22 at 4.53.28 PM.png (443×956 px, 52 KB)
Screen Shot 2021-11-22 at 4.53.38 PM.png (327×244 px, 37 KB)
Container
  • Currently the sticky header container has height: 3.75rem; (which results in 60px). The sticky header should be 50px tall. It seems like we can either remove the height rule and decrease the padding to 2px 25px, or decrease the defined height.

@alexhollender - probably happened while I was out, but just wanted to double check we have tasks for each of the above.

@alexhollender - probably happened while I was out, but just wanted to double check we have tasks for each of the above.

yes, just updated the comment above to include links to the various tasks : )