Page MenuHomePhabricator

Users who disabled the Homepage shouldn't be visible anymore by their mentor when using #mentor
Closed, DeclinedPublic

Description

We can assume that a user who disabled the Homepage is not interested by being mentored. As a consequence, we should remove this user from the view of its mentor, and remove them from the mentor/mentee relationship database. This would avoid the ex-mentee to be still visible on the mentor dashboard or in the filters their former mentor uses.

Disabling the homepage should inform the user about the loss of all benefits it provides.

Could be combined with T287915: Mentorship: allow newcomers to opt-in and opt-out of mentorship.

Event Timeline

This is already true for the mentee overview. Filters in recent changes should be fixed as a side effect of T294861: Experienced users being displayed as a result when you filter down your mentees in Recent Changes or Watchlist confuses some mentors (as soon as we sync the requirements for filters and mentee overview, it will automatically happen too).

I'm not sure if it's a good idea to remove the mentor/mentee relationship from the database though. It will mean that temporarily disabling your homepage will reset your mentee/mentor relationship. It will also mean that any possible use of #MENTOR magic keyword will suddently start returning an empty string instead of the previous mentor (which, depending on the usage, can break archived welcome notices at talk pages, etc.).

Do you have any opinion on that @Trizek-WMF?

I'm not sure if it's a good idea to remove the mentor/mentee relationship from the database though. It will mean that temporarily disabling your homepage will reset your mentee/mentor relationship. It will also mean that any possible use of #MENTOR magic keyword will suddently start returning an empty string instead of the previous mentor (which, depending on the usage, can break archived welcome notices at talk pages, etc.).

At the moment, we are at the beginning of the integration of the mentor/mentee process y communities. We are at the time where we can still change things. I think the main reasons are covered in T287915: Mentorship: allow newcomers to opt-in and opt-out of mentorship; see the first User Job Stories

As a consequence, if I opt-out:

  • my edits shouldn't be visible by my former mentor, by filtering mentees in RC and watchlist, since there is no reason to have one being able to watch my edits other than by the usual ways (special:Contribution, random appearance in RC and Watchlist, etc.)
  • #mentor should indeed return an empty result

If opting out should make #mentor return nothing, then removing the
relationship from the database in its entirety is indeed the best option.
Wasn't sure if it's a good idea to change archives where it might be used.

Do we have a way to know how many times #mentor is used now?

Do we have a way to know how many times #mentor is used now?

The global search tool can provide some insight into this. It appears that te.wikipedia is a heavy user of the keyword. https://te.wikipedia.org/wiki/%E0%B0%B5%E0%B0%BE%E0%B0%A1%E0%B1%81%E0%B0%95%E0%B0%B0%E0%B0%BF_%E0%B0%9A%E0%B0%B0%E0%B1%8D%E0%B0%9A:Mallela_srinivasarao is an example of the usage.

When interpreting the tables of the global search tool, note that it tells you how many times a given string is present in the wikitext, not how many times the keyword is used. In another words, if there's a template in the list somewhere, it might be responsible for dozens of dozens of usages (or also not, you'd need to check).

Hope this helps.

Urbanecm_WMF renamed this task from Users who disabled the Homepage shouldn't be visible anymore by their mentor to Users who disabled the Homepage shouldn't be visible anymore by their mentor when using #mentor.Aug 29 2022, 4:49 PM
kostajh subscribed.

I don't think we should make assumptions based on whether the user enabled/disabled the "Link my username to Special:Homepage" option. And we have also implemented ways for users to opt-out of mentorship on Special:Homepage since this task was filed. So I think we should decline. For now, I am putting it in Triaged.

I agree with @kostajh, the opt-out mechanism should be sufficient. Granted, users who did not get Homepage don't have access to opt-out, but considering we removed the control group on all wikis (except dewiki; tracked in T322234), I don't think that should be an issue.