Page MenuHomePhabricator
Create Task
Maniphest T294969

Deprecate and remove Database::lockTables and Database::unlockTables
Closed, ResolvedPublic
Actions

Description

This methods are rarely used sledgehammers that add complexity to the code.

Details

SubjectRepoBranchLines +/-
rdbms: remove lockTables()/unlockTables()mediawiki/coremaster+2 -195
rdbms: deprecate IMaintainableDatabase::(lock|unlock)Tables() methodsmediawiki/coremaster+5 -0
Remove old orphans.php scriptmediawiki/coremaster+0 -223
Avoid the use of Database::lockTables()mediawiki/extensions/HitCountersmaster+52 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

aaron created this task.Nov 3 2021, 7:18 PM
Restricted Application added projects: Performance-Team, Platform Engineering. · View Herald TranscriptNov 3 2021, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.Nov 3 2021, 7:36 PM
• dpifke assigned this task to aaron.Nov 8 2021, 7:54 PM
• dpifke moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
WDoranWMF removed a project: Platform Engineering.Nov 15 2021, 1:03 PM
gerritbot added a comment.Nov 18 2021, 2:39 AM

Change 739691 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/HitCounters@master] Avoid the use of Database::lockTables()

https://gerrit.wikimedia.org/r/739691

gerritbot added a project: Patch-For-Review.Nov 18 2021, 2:39 AM
gerritbot added a comment.Dec 10 2021, 1:50 AM

Change 745641 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] Remove old orphans.php script

https://gerrit.wikimedia.org/r/745641

gerritbot added a comment.Dec 13 2021, 8:33 PM

Change 739691 merged by jenkins-bot:

[mediawiki/extensions/HitCounters@master] Avoid the use of Database::lockTables()

https://gerrit.wikimedia.org/r/739691

gerritbot added a comment.Jan 6 2022, 12:11 PM

Change 745641 merged by jenkins-bot:

[mediawiki/core@master] Remove old orphans.php script

https://gerrit.wikimedia.org/r/745641

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 6 2022, 1:00 PM
gerritbot added a comment.Jan 7 2022, 12:03 AM

Change 752037 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: deprecate unused IDatabase::(lock|unlock)Tables() methods

https://gerrit.wikimedia.org/r/752037

aaron triaged this task as Medium priority.Jan 7 2022, 1:15 AM
gerritbot added a comment.Jan 19 2022, 11:58 PM

Change 752037 merged by jenkins-bot:

[mediawiki/core@master] rdbms: deprecate IMaintainableDatabase::(lock|unlock)Tables() methods

https://gerrit.wikimedia.org/r/752037

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.19; 2022-01-24); removed MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 20 2022, 12:00 AM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Patch-For-Review.Apr 5 2022, 1:41 AM
Krinkle moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.
Krinkle subscribed.

@aaron With the 1.38 cut behind us, the removal is now unblocked I believe.

gerritbot added a comment.May 3 2022, 4:36 AM

Change 788455 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: remove lockTables()/unlockTables()

https://gerrit.wikimedia.org/r/788455

gerritbot added a project: Patch-For-Review.May 3 2022, 4:36 AM
gerritbot added a comment.May 3 2022, 11:25 PM

Change 788455 merged by jenkins-bot:

[mediawiki/core@master] rdbms: remove lockTables()/unlockTables()

https://gerrit.wikimedia.org/r/788455

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 4 2022, 12:00 AM
Krinkle closed this task as Resolved.May 4 2022, 5:15 PM
Krinkle added a parent task: T299691: Break down monster class: Database.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL