Page MenuHomePhabricator

"TypeError: Cannot read properties of undefined (reading 'editingSessionId')" while posting using the new topic tool as logged out user
Closed, ResolvedPublic

Description

Testing on my local MediaWiki installation, I'm getting "TypeError: Cannot read properties of undefined (reading 'editingSessionId')" while posting using the new topic tool as logged out user.

image.png (2×3 px, 541 KB)

I can't reproduce in production or beta right now though.

Event Timeline

Change 736567 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] ArticleTargetSaver: ve.init may be undefined

https://gerrit.wikimedia.org/r/736567

Change 736567 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ArticleTargetSaver: ve.init may be undefined

https://gerrit.wikimedia.org/r/736567

matmarex added a project: Skipped QA.

I don't see any occurrences in Logstash, so I won't bother backporting.

I have reports via @Patriccck of this happening at cswiki, but I can't reproduce myself.

Browsers: Chrome, Internet Explorer, originally reported by David V. to me, forwarded to @Whatamidoing-WMF

image.png (509×1 px, 602 KB)

Oops… Thanks for the note. I'll schedule a backport for Monday: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20211108T1900

I still can't find any occurrences in Logstash, so maybe I should trust it less.

Change 737077 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.7] ArticleTargetSaver: ve.init may be undefined

https://gerrit.wikimedia.org/r/737077

Oops… Thanks for the note. I'll schedule a backport for Monday: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20211108T1900

I still can't find any occurrences in Logstash, so maybe I should trust it less.

Waiting to resolve until patch lands on Monday.

Just to confirm this error is occurring for me.

Change 737077 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.7] ArticleTargetSaver: ve.init may be undefined

https://gerrit.wikimedia.org/r/737077

Mentioned in SAL (#wikimedia-operations) [2021-11-08T19:31:00Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.7/extensions/VisualEditor/modules/ve-mw/preinit/ve.init.mw.ArticleTargetSaver.js: 9d7cde492a69dc4e18403f3dbacd2de27c3f05e0: ArticleTargetSaver: ve.init may be undefined (T294981) (duration: 00m 55s)

matmarex removed a project: Patch-For-Review.

@Seddon confirmed on IRC that this fixed the issue for him.

As for why the failures aren't visible in Logstash: I think it's because they're technically not uncaught errors, because they're caught by the promise handling, so the usual logging doesn't catch them.

They would instead be visible in the logs of save failures ('editattemptstep' schema), but that code had an unrelated bug (fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/736584).

ppelberg claimed this task.