Page MenuHomePhabricator

Add an image: prevent desktop usage
Closed, ResolvedPublic

Description

For Iteration 1 of "add an image", we are only building for the mobile skin experience. Therefore, we need to prevent users from encountering and attempting the task on the desktop skin.

The only users who really should end up in the situation are those in the mobile treatment group ("Mobile A") from T294737: Add an image: experiment. They are the only ones who will even have the "add an image" task available in their difficulty filters. And though they will have created their accounts from mobile, they may go to their homepage from desktop.

For the case above, and for any other way that the user manages to have image tasks in their feed on desktop, here is what they should experience:

  • Their filters should be unchanged from their mobile experience. If they haven't changed their filters since creating their account, it will only have "add an image" selected.
  • Their feed should be unchanged from their mobile experience. If they haven't changed their filters, since creating their account, there should be only image tasks in the feed.
  • When they click on an image task, it should not open up -- rather they should get a dialog:
    • "Image suggestions are only available on mobile devices. Adjust your difficulty levels to see other types of edits or use your mobile device to work on image suggestions."
    • The dialog should have one button: "Got it".
    • The dialog should look and feel similarly to the one for T285587: [EPIC] "Add an image" Iteration 1. Below is the mockup of that dialog.
    • If the user is in the rare edge case of both having completed all their image suggestions for the day and being on desktop, it should be the "quality gate" dialog that they see when clicking on a task, not the "mobile only" dialog.
    • We do not need instrumentation around this dialog because the case will be rare.
  • We know that there are some additional edge cases in which a user could encounter the desktop experience by switching their skin while editing. We are okay with those cases occurring, even though they result in the user being in the desktop experience.

image.png (1×738 px, 167 KB)

Event Timeline

LGTM.

If the user is in the rare edge case of both having completed all their image suggestions for the day and being on desktop, it should be the "quality gate" dialog that they see when clicking on a task, not the "mobile only" dialog.

I'll see how easily that fits in with the quality gates; it might be worth dropping this requirement in the interests of time. E.g. if the user is in that rare edge case, they would just see the "mobile only" dialog and not the "quality gate" one. But will try to get it done the way it's proposed in the description.

Change 736783 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Show alert dialog if user clicks on task on desktop

https://gerrit.wikimedia.org/r/736783

We do not need instrumentation around this dialog because the case will be rare.

It was trivial to add, so I included it in the patch for T294674: Image instrumentation: minimal quality gate

If the user is in the rare edge case of both having completed all their image suggestions for the day and being on desktop, it should be the "quality gate" dialog that they see when clicking on a task, not the "mobile only" dialog.

I'll see how easily that fits in with the quality gates; it might be worth dropping this requirement in the interests of time. E.g. if the user is in that rare edge case, they would just see the "mobile only" dialog and not the "quality gate" one. But will try to get it done the way it's proposed in the description.

@kostajh -- it's fine to skip this requirement. I just wanted to include it in case you had to make the choice of which one to show.

Change 736783 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Show alert dialog if user clicks on task on desktop

https://gerrit.wikimedia.org/r/736783

@RHo I suppose this ticket describes two popups - one with the text "Image suggestions are only available on mobile devices. Adjust your difficulty levels ..." (when a user clicks on the article add image card on Homepage on the desktop) and another one - completed max number of daily suggestions (the screenshot in the task description).

Both dialog popups do not have a new line for "Adjust your difficulty levels..." - I filed it as another task: T296265. Otherwise all seem fine to me. Closing the task as Resolved.