Date of birth validation in membership form
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	CorinnaHillebrand_WMDE
	Nov 4 2021, 10:39 AM

Description

Current behaviour: Users who want to apply for a membership can enter random characters (letters, numbers,..) in the date of birth form field,
the validation is treated as optional, only a hint is shown.

Related Objects

Mentioned Here: T295289: Submitting the membership form (sometimes) results in a blank page

Event Timeline

CorinnaHillebrand_WMDE created this task.Nov 4 2021, 10:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2021, 10:39 AM

Maintenance_bot added a project: WMDE-FUN-Team.Nov 4 2021, 10:45 AM

Respected Mentor, Please help me in this task .I am intersested in to do so. .Please help me how to start this.?

@786: Welcome to Wikimedia! Please refer to https://www.mediawiki.org/wiki/New_Developers - thanks a lot.

kai.nissen moved this task from Backlog to Current Sprint on the WMDE-Fundraising-Tech board.Nov 5 2021, 8:35 AM

CorinnaHillebrand_WMDE claimed this task.Nov 8 2021, 9:59 AM

CorinnaHillebrand_WMDE moved this task from Backlog to In Progress / Deployment (max. 3 tasks) on the WMDE-FUN-Funban-2021 board.

This change should also fix T295289

https://github.com/wmde/fundraising-frontend-content/commit/b4de560c6b314a357c8f42bacb9df5a104c92150
https://gitlab.com/fun-tech/fundraising-app-frontend/-/merge_requests/129

changes in https://github.com/wmde/fundraising-memberships/blob/a24ad38d0694751312f6e2cbaa043bdb3928cee9/src/UseCases/ApplyForMembership/MembershipApplicationValidator.php#L134
should also be made because strtotime() assumes MM/DD/YYYY

CorinnaHillebrand_WMDE moved this task from In Progress / Deployment (max. 3 tasks) to Code Review (max. 3 tasks) on the WMDE-FUN-Funban-2021 board.Nov 11 2021, 11:24 AM

CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Nov 11 2021, 11:27 AM

CorinnaHillebrand_WMDE claimed this task.Nov 12 2021, 2:59 PM

CorinnaHillebrand_WMDE moved this task from Code Review (max. 3 tasks) to In Progress / Deployment (max. 3 tasks) on the WMDE-FUN-Funban-2021 board.

I deployed to https://testing01.wikimedia.customers.manitu.net/apply-for-membership
the date of birth should now validate correctly:

allow empty field ( updated regex allows it)
allow . and / notation
require reasonable dates ( e.g. not 31.22.1870 )
still store all valid fields correctly

kai.nissen removed kai.nissen as the assignee of this task.Nov 17 2021, 10:16 AM

kai.nissen moved this task from Acceptance Testing (Banners) to Code Review (max. 3 tasks) on the WMDE-FUN-Funban-2021 board.

kai.nissen subscribed.

PR is squashed,
refactored code got again deployed to https://testing01.wikimedia.customers.manitu.net/apply-for-membership

CorinnaHillebrand_WMDE assigned this task to kai.nissen.Nov 17 2021, 2:53 PM

CorinnaHillebrand_WMDE moved this task from Code Review (max. 3 tasks) to Acceptance Testing on the WMDE-FUN-Funban-2021 board.

CorinnaHillebrand_WMDE moved this task from Acceptance Testing to Done on the WMDE-FUN-Funban-2021 board.Nov 18 2021, 2:30 PM

kai.nissen closed this task as Resolved.Jan 3 2022, 9:59 AM

kai.nissen removed kai.nissen as the assignee of this task.

Date of birth validation in membership formClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Date of birth validation in membership form
Closed, ResolvedPublic
Actions