The User Menu drop down stays open even after navigating away from a page
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Nov 4 2021, 10:10 PM

Description

Steps to reproduce:

Go to this page: https://en.wikipedia.org/wiki/Main_Page.

Open the User Menu and choose any of the options from the drop down to navigate away from this page.

Click on the back button on browser.

Observed Result: The User Menu drop down stayed open even after navigating away from the page.

Screen Shot 2021-11-04 at 3.01.47 PM.png (956×2 px, 547 KB)

Environment: Beta cluster, en.wiki.

QA steps

Please perform the following steps in Safari, Chrome, Edge, and Firefox:

Login to beta and go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?vectorstickyheader=1&useskinversion=2
Click the user menu
Click the Talk menu option
After talk page has loaded, click your browser's "back" button
Verify that the user menu is not open

Details

	Subject	Repo	Branch	Lines +/-
	Close .vector-menu-dropdown menus in modern Vector beforeunload	mediawiki/skins/Vector	master	+14 -0

Customize query in gerrit

Related Objects

Mentioned In: T293719: [SPIKE] Editing Team Review of Sticky Header
Mentioned Here: T298910: TypeError: document.querySelectorAll(...).forEach is not a function

Event Timeline

Ryasmeen created this task.Nov 4 2021, 10:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2021, 10:10 PM

Ryasmeen mentioned this in T293719: [SPIKE] Editing Team Review of Sticky Header.Nov 4 2021, 10:15 PM

Ryasmeen updated the task description. (Show Details)Nov 4 2021, 11:17 PM

ovasileva triaged this task as Medium priority.Nov 11 2021, 10:51 AM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

This is a browser feature. It could be argued that it's a useful feature or not. For example, if I open the user menu and click watchlist, clicking back will show me the user menu still open.

If we want to fix it, we just need to make sure we uncheck all menus in a beforeunload event but I'd like to check before we push that patch. @alexhollender can you confirm how this should behave?

@Volker_E it would be great if you could add your opinions here

Behavior is just true for the user menu links and not for any other links. Not even if we're providing some sort of focus for the menu item clicked, I'd see a user benefit here. If you click Watchlist and another link on the Watchlist page and then go back twice, suddenly the user menu is still open. It's more confusing than anything else IMO.

@Volker_E it's true for all dropdowns. So this is also true for the language button (with JS disabled) and the more menu. This is also how it works for legacy Vector and other skins.

If we want to fix this I'd suggest putting the fix inside the core mediawiki.checkboxtoggle module to fix all cases.

Suggest adding the code

window.onbeforeunload = function () {
  $('.vector-menu-checkbox').prop('checked', false)
};

This will probably need to be in Vector for now. If we're more ambitious about this, we'd add this to mediawiki.checkboxtoggle and add a standard clss e.g. mw-menu-checkbox.

Jdlrobson removed • alexhollender_WMF as the assignee of this task.Dec 3 2021, 7:47 PM

LGoto set the point value for this task to 2.Dec 7 2021, 6:37 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

• nray claimed this task.Dec 8 2021, 10:36 PM

• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 746975 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Close .vector-menu-dropdown menus in modern Vector beforeunload

https://gerrit.wikimedia.org/r/746975

gerritbot added a project: Patch-For-Review.Dec 14 2021, 12:34 AM

• nray removed • nray as the assignee of this task.Dec 14 2021, 12:35 AM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

• nray subscribed.

LGoto assigned this task to bwang.Dec 14 2021, 6:08 PM

Jdlrobson reassigned this task from bwang to Edtadros.Dec 14 2021, 10:28 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson added a subscriber: bwang.

Change 746975 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Close .vector-menu-dropdown menus in modern Vector beforeunload

https://gerrit.wikimedia.org/r/746975

• nray updated the task description. (Show Details)Dec 14 2021, 10:57 PM

• nray updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 14 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2021, 11:10 PM

This has caused T298910

Now fixed. Back to QA :)

This is in production.

Verified in production. Resolving.
QA:
Login to beta and go to https://en.wikipedia.org/wiki/Main_Page
Click the user menu
Click the Talk menu option
After talk page has loaded, click your browser's "back" button
Verify that the user menu is not open

ovasileva closed this task as Resolved.Feb 17 2022, 6:35 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 17 2022, 6:35 PM

	F34730481: Screen Shot 2021-11-04 at 3.01.47 PM.png
	Nov 4 2021, 10:10 PM

The User Menu drop down stays open even after navigating away from a page Closed, ResolvedPublic2 Estimated Story PointsActions