Page MenuHomePhabricator
Create Task
Maniphest T295137

Kartographer pulls versioned live data for old revisions
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We missed one place where Kartographer would still pull a latest-revision map: when the live data is missing and the user is viewing an old revision of the page.

Support versioned maps here, put behind the existing feature flag wgKartographerVersionedLiveMaps.

Details

SubjectRepoBranchLines +/-
Get versioned live datamediawiki/extensions/Kartographerwmde-maps-revid+646 -557
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Nov 5 2021, 12:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2021, 12:19 PM
gerritbot added a comment.Nov 5 2021, 12:20 PM

Change 737021 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@wmde-maps-revid] Bump dependencies: mapdata with versioned map support

https://gerrit.wikimedia.org/r/737021

gerritbot added a project: Patch-For-Review.Nov 5 2021, 12:20 PM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 5 2021, 2:07 PM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Nov 10 2021, 10:45 AM
awight added a project: WMDE-TechWish-Sprint-2021-11-10.Nov 10 2021, 10:56 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2021-11-10 board.Nov 10 2021, 10:57 AM
awight set the point value for this task to 1.Nov 10 2021, 11:04 AM
gerritbot added a comment.Nov 12 2021, 12:47 PM

Change 737021 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@wmde-maps-revid] Get versioned live data

https://gerrit.wikimedia.org/r/737021

Maintenance_bot removed a project: Patch-For-Review.Nov 12 2021, 1:10 PM
lilients_WMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2021-11-10 board.Nov 15 2021, 8:43 AM
thiemowmde moved this task from In sprint to Ready for story time on the WMDE-GeoInfo-FocusArea board.May 4 2022, 9:57 AM
awight renamed this task from Kartographer pulls versioned live data to Kartographer pulls versioned live data for old revisions.May 5 2022, 7:59 AM

After T307650: [versioned maps] Interactive map fails to render after save, I think this might already be resolved.

awight closed this task as Resolved.Jun 3 2022, 10:33 AM
awight claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL