Page MenuHomePhabricator
Create Task
Maniphest T295173

Interface 'Wikimedia\NormalizedException' not found
Closed, ResolvedPublic
Actions

Description

I installed MW from https://releases.wikimedia.org/mediawiki/1.37/mediawiki-1.37.0-rc.1.tar.gz

It looks like some files are missing from the distribution:

[exception] [acc53f38b0b7ec6e1569329b] /rest.php/localhost/v3/transform/wikitext/to/html   Error: Interface 'Wikimedia\NormalizedException\INormalizedException' not found
#0 /var/www/html/includes/AutoLoader.php(117): require()
#1 [internal function]: AutoLoader::autoload(string)
#2 /var/www/html/includes/Revision/IncompleteRevisionException.php(32): spl_autoload_call(string)
#3 /var/www/html/includes/AutoLoader.php(117): require(string)
#4 [internal function]: AutoLoader::autoload(string)
#5 /var/www/html/includes/Revision/SlotRecord.php(348): spl_autoload_call(string)
#6 /var/www/html/includes/Revision/SlotRecord.php(378): MediaWiki\Revision\SlotRecord->getField(string)
#7 /var/www/html/includes/Revision/SlotRecord.php(558): MediaWiki\Revision\SlotRecord->getStringField(string)
#8 /var/www/html/includes/Revision/RevisionSlots.php(205): MediaWiki\Revision\SlotRecord->getSha1()
#9 [internal function]: MediaWiki\Revision\RevisionSlots::MediaWiki\Revision\{closure}(NULL, MediaWiki\Revision\SlotRecord)
#10 /var/www/html/includes/Revision/RevisionSlots.php(207): array_reduce(array, Closure, NULL)
#11 /var/www/html/includes/Revision/MutableRevisionRecord.php(371): MediaWiki\Revision\RevisionSlots->computeSha1()
#12 /var/www/html/vendor/wikimedia/parsoid/extension/src/Config/PageConfig.php(223): MediaWiki\Revision\MutableRevisionRecord->getSha1()
#13 /var/www/html/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(744): MWParsoid\Config\PageConfig->getRevisionSha1()
#14 /var/www/html/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(970): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->addMetaData(Wikimedia\Parsoid\Config\Env, Wikimedia\Parsoid\DOM\Compat\Document)
#15 /var/www/html/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(987): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(Wikimedia\Parsoid\DOM\Compat\Element)
#16 /var/www/html/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(1004): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->process(Wikimedia\Parsoid\DOM\Compat\Element)
#17 /var/www/html/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(178): Wikimedia\
Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#18 /var/www/html/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(307): Wik
imedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#19 /var/www/html/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(106): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#20 /var/www/html/vendor/wikimedia/parsoid/src/Parsoid.php(166): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#21 /var/www/html/vendor/wikimedia/parsoid/src/Parsoid.php(198): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Re-add wikimedia/normalized-exceptionmediawiki/vendorREL1_37+343 -7
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReedyT289585 Release MW 1.37.0
 ResolvedReedyT295176 Release 1.37.0-rc.2
 ResolvedReedyT295173 Interface 'Wikimedia\NormalizedException' not found

Event Timeline

jberkel created this task.Nov 5 2021, 4:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2021, 4:50 PM
DannyS712 added projects: NormalizedException, MediaWiki-Vendor.Nov 5 2021, 4:54 PM
DannyS712 added subscribers: Jdforrester-WMF, DannyS712.

Removed from vendor in T289589: Prune /vendor for REL1_37 - rMWVD1a473e9bc615: Prune /vendor for REL1_37

Reedy removed a project: NormalizedException.Nov 5 2021, 4:57 PM
gerritbot added a comment.Nov 5 2021, 5:00 PM

Change 737094 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_37] Re-add wikimedia/normalized-exception

https://gerrit.wikimedia.org/r/737094

gerritbot added a project: Patch-For-Review.Nov 5 2021, 5:00 PM
Reedy subscribed.Nov 5 2021, 5:04 PM

I don't understand offhand how CI passed any patch to REL1_37 after we removed this?

https://github.com/wikimedia/mediawiki/blob/REL1_37/tests/phpunit/unit/includes/exception/MWExceptionHandlerTest.php uses NormalizedException

Or is CI just installing the packages its missing and doesn't care?

I've double checked, and as far as MW core is concerned, only wikimedia/normalized-exception is missing

Package operations: 1 install, 5 updates, 6 removals
  - Removing wikimedia/testing-access-wrapper (2.0.0)
  - Removing psr/simple-cache (1.0.1)
  - Removing psr/http-factory (1.0.1)
  - Removing justinrainbow/json-schema (5.2.10)
  - Removing jakobo/hotp-php (v2.0.0)
  - Removing christian-riesen/base32 (1.4.0)
  - Upgrading guzzlehttp/promises (1.4.0 => 1.5.1): Extracting archive
  - Upgrading guzzlehttp/psr7 (1.7.0 => 1.8.3): Extracting archive
  - Upgrading pear/pear_exception (v1.0.1 => v1.0.2): Extracting archive
  - Upgrading pear/pear-core-minimal (v1.10.10 => v1.10.11): Extracting archive
  - Installing wikimedia/normalized-exception (v1.0.1): Extracting archive
  - Upgrading wikimedia/zest-css (2.0.1 => 2.0.2): Extracting archive
Reedy mentioned this in T295175: Have at least one job running REL1_XX with its appropriate vendor repo.Nov 5 2021, 5:11 PM
Reedy added a parent task: T295176: Release 1.37.0-rc.2.Nov 5 2021, 5:13 PM
gerritbot added a comment.Nov 5 2021, 5:15 PM

Change 737094 merged by Reedy:

[mediawiki/vendor@REL1_37] Re-add wikimedia/normalized-exception

https://gerrit.wikimedia.org/r/737094

Reedy closed this task as Resolved.Nov 5 2021, 5:23 PM
Reedy claimed this task.

Thanks for the report. Definitely seems worthwhile doing another rc. I've filed a task for that, and one for hopefully trying to prevent this from happening in future

jberkel added a comment.Nov 5 2021, 5:27 PM

Thanks for fixing this so quickly, I'll wait for rc2 and re-test.

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2021, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits