Page MenuHomePhabricator

Taint-check demo broken with: munmap() failed: [28] Invalid argument
Closed, ResolvedPublicBUG REPORT

Description

https://doc.wikimedia.org/mediawiki-tools-phan-SecurityCheckPlugin/master/demos/

Clicking "analyze" results in the following error being printed multiple times in the output area:

munmap() failed: [28] Invalid argument

AFAIK nothing has changed in the demo source, so it might have been caused e.g. by a OS upgrade or something.

Event Timeline

Daimona triaged this task as High priority.Nov 6 2021, 5:09 PM

I tried to self-merge https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/SecurityCheckPlugin/+/737040 to trigger the demo job and see if a rebuild fixed the issue, but it didn't.

I could reproduce this issue on the toolforge instance at https://taintcheck.toolforge.org/. At this point, I think it's caused by some change in newer emscripten. Now trying again with 2.0.21, which used to work on toolforge.

This is indeed caused by some change in emscripten, since it works with 2.0.21 but not 2.0.34 (latest version). I'm going to change the docker image to always use 2.0.21.

Change 737205 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] dockerfiles: [mediawiki-phan-taint-check-demo] Lock emscripten to 2.0.21

https://gerrit.wikimedia.org/r/737205

Change 737205 merged by jenkins-bot:

[integration/config@master] dockerfiles: [mediawiki-phan-taint-check-demo] Lock emscripten to 2.0.21

https://gerrit.wikimedia.org/r/737205

Mentioned in SAL (#wikimedia-releng) [2021-11-07T21:35:46Z] <James_F> Docker: Publishing mediawiki-phan-taint-check-demo 0.1.5 for T295228

Change 737211 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: [mw-tools-phan-demos-publish] Bump to pinned emscripten image

https://gerrit.wikimedia.org/r/737211

Change 737211 merged by jenkins-bot:

[integration/config@master] jjb: [mw-tools-phan-demos-publish] Bump to pinned emscripten image

https://gerrit.wikimedia.org/r/737211

Working again now! Yay!