Page MenuHomePhabricator

VE does not replicate T6780 (new paragraph on multiline table cell), shows it as {br}
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Arthur2e5
Nov 7 2021, 1:12 PM
Referenced Files
F34909367: Screenshot 2022-01-06 at 15.58.24.png
Jan 6 2022, 3:01 PM
F34909368: Screenshot 2022-01-06 at 15.59.00.png
Jan 6 2022, 3:01 PM
F34736683: image.png
Nov 7 2021, 1:15 PM
F34736679: image.png
Nov 7 2021, 1:12 PM
F34736677: image.png
Nov 7 2021, 1:12 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Make a table cell.
  • Add a line break and type something else.
{|class="wikitable"
|Foo
bar
|}
  • Save page.
  • Observe.
  • Open in VE.

What happens?:
A td cell with foo{p}bar{/p} appears on real render; this is T6780. But VE does not show the extra paragraph space, instead showing it like a {br}.

What should have happened instead?:
These two would be consistent. Personally I feel it makes more sense if we somehow fix T6780 too (I prefer making a break only cause a space like in other places) instead of making VE bug-compatible.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
It's on English Wikipedia. See https://en.wikipedia.org/w/index.php?title=Alder_Lake_(microprocessor)&oldid=1054000672 for a real-life example, and for the test https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&oldid=1054001685.

Test in VE

image.png (228×446 px, 8 KB)

Test in real render

image.png (228×578 px, 8 KB)

Event Timeline

Arthur2e5 updated the task description. (Show Details)
Arthur2e5 updated the task description. (Show Details)

Change 740267 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Tweak paragraph margins in multi-line table cells to match view mode

https://gerrit.wikimedia.org/r/740267

The rendering in VisualEditor actually has the same behavior as T6780, but we were hiding all margins between the lines, so it wasn't obviously visible.

Test cases:

1{| class=wikitable
2| aaa
3bbb
4|}
5
6{| class=wikitable
7|
8aaa
9bbb
10|}
11
12{| class=wikitable
13| aaa
14
15bbb
16|}
17
18{| class=wikitable
19|
20aaa
21
22bbb
23|}

Change 740267 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Tweak paragraph margins in multi-line table cells to match view mode

https://gerrit.wikimedia.org/r/740267

Change 745276 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2947b78df)

https://gerrit.wikimedia.org/r/745276

Change 745276 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2947b78df)

https://gerrit.wikimedia.org/r/745276

matmarex edited projects, added Editing QA; removed Patch-For-Review.

@Arthur2e5 I hope it's not too disappointing to see this issue fixed in the "wrong" direction :)

As expected, it is consistent across both
VE:

Screenshot 2022-01-06 at 15.59.00.png (1×302 px, 44 KB)

Real render:
Screenshot 2022-01-06 at 15.58.24.png (1×414 px, 48 KB)

ppelberg claimed this task.