Page MenuHomePhabricator

SpecialSpecialPages often shows wrong page title page on mobile.
Closed, ResolvedPublicBUG REPORT

Description

The page title <h1> content of Special:SpecialPages on mobile site is being replaced with the page title of a userpage including the registration date tagline.

I once noticed this, but there was no way to reproduce and it disappeared.

Now it seems to be somehow reproducible.

Link: https://en.m.wikipedia.org/wiki/Special:SpecialPages (Following this link on desktop didn't work for me for the first time. But it did on refresh.)

Correct title on desktop siteMobile site (not logged in)Mobile site (logged in)Mobile phone
Screen Shot 2021-11-09 at 7.24.36 PM.png (788×1 px, 222 KB)
Screen Shot 2021-11-09 at 6.58.57 PM.png (795×1 px, 138 KB)
Screen Shot 2021-11-09 at 7.00.33 PM.png (736×1 px, 127 KB)
1636482688616.jpg (1×1 px, 494 KB)

Browser is Google Chrome 95.0.4638.54 (Official Build) (x86_64)

Event Timeline

Umherirrender added a subscriber: Umherirrender.

It seems that is the relevant page name as seen in the html for javascript is used here.

It is set in the constructor for this special page and that mixed it up.
https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/033148792e9d75423375beec4785674aaa3d0be6/includes/Specials/SpecialHomepage.php#77

SpecialPage constructor must be cheap and should not add access or change anything on the context, because it is using the global context, ending up in this here.

Change 737785 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Move hack out of SpecialHomepage::__construct

https://gerrit.wikimedia.org/r/737785

Change 737891 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Homepage: Stop setting relevant title on mobile

https://gerrit.wikimedia.org/r/737891

Change 737785 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Move hack out of SpecialHomepage::__construct

https://gerrit.wikimedia.org/r/737785

kostajh triaged this task as Medium priority.Nov 10 2021, 2:54 PM

Change 737891 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: Stop setting relevant title on mobile

https://gerrit.wikimedia.org/r/737891