SpecialSpecialPages often shows wrong page title page on mobile.
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ammarpad
	Nov 9 2021, 6:48 PM

Description

The page title <h1> content of Special:SpecialPages on mobile site is being replaced with the page title of a userpage including the registration date tagline.

I once noticed this, but there was no way to reproduce and it disappeared.

Now it seems to be somehow reproducible.

Link: https://en.m.wikipedia.org/wiki/Special:SpecialPages (Following this link on desktop didn't work for me for the first time. But it did on refresh.)

Correct title on desktop site	Mobile site (not logged in)	Mobile site (logged in)	Mobile phone

Browser is Google Chrome 95.0.4638.54 (Official Build) (x86_64)

Details

	Subject	Repo	Branch	Lines +/-
	Homepage: Stop setting relevant title on mobile	mediawiki/extensions/GrowthExperiments	master	+0 -10
	Move hack out of SpecialHomepage::__construct	mediawiki/extensions/GrowthExperiments	master	+10 -10

Customize query in gerrit

Event Timeline

Ammarpad created this task.Nov 9 2021, 6:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2021, 6:48 PM

Ammarpad added projects: MinervaNeue, MobileFrontend.Nov 9 2021, 6:49 PM

It seems that is the relevant page name as seen in the html for javascript is used here.

It is set in the constructor for this special page and that mixed it up.
https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/033148792e9d75423375beec4785674aaa3d0be6/includes/Specials/SpecialHomepage.php#77

SpecialPage constructor must be cheap and should not add access or change anything on the context, because it is using the global context, ending up in this here.

Change 737785 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Move hack out of SpecialHomepage::__construct

https://gerrit.wikimedia.org/r/737785

gerritbot added a project: Patch-For-Review.Nov 9 2021, 8:55 PM

Aklapper edited projects, added GrowthExperiments, Mobile; removed MobileFrontend, MinervaNeue.Nov 9 2021, 9:23 PM

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Nov 10 2021, 4:51 AM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 737891 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Homepage: Stop setting relevant title on mobile

https://gerrit.wikimedia.org/r/737891

kostajh claimed this task.Nov 10 2021, 11:16 AM

Change 737785 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Move hack out of SpecialHomepage::__construct

https://gerrit.wikimedia.org/r/737785

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 10 2021, 12:00 PM

kostajh triaged this task as Medium priority.Nov 10 2021, 2:54 PM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 22 2021, 1:50 AM

Change 737891 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: Stop setting relevant title on mobile

https://gerrit.wikimedia.org/r/737891

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 22 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2021, 3:11 AM

Umherirrender closed this task as Resolved.Nov 24 2021, 7:43 PM

	F34739454: Screen Shot 2021-11-09 at 7.24.36 PM.png
	Nov 9 2021, 6:48 PM

	F34739467: Screen Shot 2021-11-09 at 6.58.57 PM.png
	Nov 9 2021, 6:48 PM

	F34739469: Screen Shot 2021-11-09 at 7.00.33 PM.png
	Nov 9 2021, 6:48 PM

SpecialSpecialPages often shows wrong page title page on mobile.Closed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

SpecialSpecialPages often shows wrong page title page on mobile.
Closed, ResolvedPublicBUG REPORT
Actions