Can we hide ads like these?
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
We theoretically have the option that disables this kind of thing turned on, but I will investigate. May be worth an upstream complaint.
Comment Actions
I filed an issue upstream after checking that we definitely have hide_third_party_offers set:
https://gitlab.com/gitlab-org/gitlab/-/issues/376211
Looking at this a little closer, my guess is that this boolean only governs a system for promoting 3rd-party products, and that at least some of the various promotions scattered throughout the interface aren't affected by it.
For clarity, I don't really expect action from GitLab on this one. They've made it pretty clear on past issues that they are not interested in making changes that don't align with their business model. Still, no harm in filing it.
Comment Actions
This has actually gotten some traction from upstream - see recent traffic on https://gitlab.com/gitlab-org/gitlab/-/issues/376211
Comment Actions
Upstream closed https://gitlab.com/gitlab-org/gitlab/-/issues/376211 as implemented. Can we verify and resolve here if fix too?
Comment Actions
No clue if hide_third_party_offers is set, as curl --request GET --header "PRIVATE-TOKEN: xxx" --url "https://gitlab.wikimedia.org/api/v4/application/settings" (with a personal token with the required scopes api and read_api) gives me a {"message":"403 Forbidden"}...
Currently any issue on https://gitlab.wikimedia.org/groups/repos/-/issues shows me an advertisement:
Comment Actions
After entering into admin mode in a browser session I can see that API's response.
Currently any issue on https://gitlab.wikimedia.org/groups/repos/-/issues shows me an advertisement:
I had forgotten that we have some repos which are using gitlab's issues system rather than Phabricator. One possible solution for that particular open-core upsell advertisement exposure would be to disable issues in those repos.
Comment Actions
According to the GNOME sysadmins in https://gitlab.gnome.org/Infrastructure/Infrastructure/-/issues/2109 we cannot disable GitLab SharewareFreemium advertisements (like the screenshot I posted in T295453#11356659) as they are not third-party advertisements.
One possible solution for that particular open-core upsell advertisement exposure would be to disable issues in those repos.
T304614: GitLab Issues experiment with Research was called an "experiment".
I wonder when/whether WMF re-evaluate experiments (and based on which criteria).
Comment Actions
I think the issue that @brennen reported upstream is actually fixed. Unfortunately it was just a single banner on the /-/security/configuration page for each repo and not a general stop on all the open-core upgrade nags.