The infobox and popup should display properties from different sources in a given order [L]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	phuedx
	Nov 10 2021, 11:59 AM

Project Tags

Referenced Files

None

Subscribers

Description

Background

Following on from the discussion around T286662: Display block and contribs info in popup and infobox [S]:

Several members of Anti-Harassment-Team noticed that the current way that the mw.IpInfo.IpInfoWidget class backing the infobox and popup is configured to display items can't be used to display items from different sources in a given order across multiple columns, i.e.

Source A. Property 1	Source A. Property 3	Source C. Property 1
Source A. Property 2	Source A. Property 4	Source C. Property 2
Source B. Property 1	Source A. Property 5
	Source A. Property 6

Acceptance criteria

The widget can be configured to display items from multiple sources in order
The widget can be configured to display items across one or more columns
There's no regression in how the popup displays items

Notes

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Use separate widgets for the popup and info box	Tchanders	mediawiki/extensions/IPInfo	master	+121 -100

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	kostajh	T285977 IP Info
Resolved	kostajh	T287647 [Epic] IP Information accordion on Special:Contribs
Resolved	Tchanders	T295462 The infobox and popup should display properties from different sources in a given order [L]

Event Timeline

phuedx created this task.Nov 10 2021, 11:59 AM

Herald added a subscriber: Aklapper. · View Herald TranscriptNov 10 2021, 11:59 AM

phuedx renamed this task from The widget should display properties from different sources in a given order to The infobox and popup should display properties from different sources in a given order.Nov 10 2021, 12:00 PM

phuedx updated the task description. (Show Details)

phuedx moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.

phuedx added a parent task: T287647: [Epic] IP Information accordion on Special:Contribs.

phuedx updated the task description. (Show Details)

phuedx updated the task description. (Show Details)Nov 10 2021, 12:29 PM

ARamirez_WMF renamed this task from The infobox and popup should display properties from different sources in a given order to The infobox and popup should display properties from different sources in a given order [L].Nov 10 2021, 5:32 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.Nov 15 2021, 7:11 PM

• Niharika edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team.

Tchanders claimed this task.Nov 18 2021, 1:54 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.

Change 742518 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Use separate widgets for the popup and info box

https://gerrit.wikimedia.org/r/742518

gerritbot added a project: Patch-For-Review.Nov 29 2021, 7:10 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Nov 29 2021, 7:29 PM

Change 742518 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Use separate widgets for the popup and info box

https://gerrit.wikimedia.org/r/742518

phuedx moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Dec 1 2021, 5:31 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 1 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2021, 6:10 PM

phuedx mentioned this in T286662: Display block and contribs info in popup and infobox [S].Dec 2 2021, 2:32 PM

Moved to done
Testing for this will be done in https://phabricator.wikimedia.org/T287647

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment-Team (The Letter Song) board.Dec 9 2021, 8:09 PM

• Niharika closed this task as Resolved.Feb 17 2022, 1:47 AM

• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM

The infobox and popup should display properties from different sources in a given order [L]Closed, ResolvedPublicActions