(Reposted from WP:VPT)
Replacing this line with insertLinkTitleInputField.getField().setValue( match[ 1 ] ); seems to do the job, but I'm surprised the function 1) keeps underscores instead of turning them into spaces and 2) doesn't decode percent encodings. I bet users of wikis in other languages have found it useless.

Change 738599 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Fix bug when target looks like internal link

https://gerrit.wikimedia.org/r/738599

We should def honor the previous functionality if it used to convert it accordingly. Will prioritize in the to be estimated column so we could add to sprint

Change 738599 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Fix bug when target looks like internal link

https://gerrit.wikimedia.org/r/738599

@Samwilson I am finding that when I get the dialog asking me whether I want an internal or external link, if I click "Internal link" the "To an external web page" radio is still selected. If I don't notice this, I will end up entering an invalid link.

This was not the case before (in WikiEditor 0.5.3 (afa4f07) 06:14, 19 August 2021). Selecting "Internal link" would also select the "To wiki page" radio button.

Enter a full URL:

Click "Insert link":

Click "Internal link":

Click "Insert link":

Change 745127 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Set link type radio when confirming looks-like internal

https://gerrit.wikimedia.org/r/745127

Thanks @dom_walden, good point. Fixed in the above patch.

Notes for QA:

1. Using the source editor, start editing any page on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Random)
2. Open the "Insert link" dialog
   
3. Find any other page on the same beta wiki. Copy the entire URL from the address bar.
   • So, if you are editing on beta enwiki, if you go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Random it will take you to a random page
4. In the first input field, enter the full URL you copied in step 3.
   • So, if you are editing on beta enwiki, you could enter: https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_diff_test_0.18270253102627854
     
5. Click "Insert link" or press enter.
6. You should see a dialog like below.
   
7. Depending on which of the two buttons you click on in this dialog, one of two things will happen:
   • a) If you click "Internal link", the URL you entered will be stripped down so only the page's title will display (e.g. Selenium_diff_test_0.18270253102627854) and the "To a wiki page" radio button will be selected. If you then click "Insert link" an internal link will be added to the page. This will be something like [[Selenium_diff_test_0.18270253102627854]].
     
   • b) If you click "External link", the URL you entered should be untouched and it will insert an external link. Something like https://en.wikipedia.beta.wmflabs.org/wiki/Selenium%20diff%20test%200.18270253102627854 or [https://en.wikipedia.beta.wmflabs.org/wiki/Selenium%20diff%20test%200.18270253102627854 https://en.wikipedia.beta.wmflabs.org/wiki/Selenium diff test 0.18270253102627854].
   • N.B. Currently I notice that b) inserts the wikitext immediately after you click "External link" whereas a) takes you back to the "Insert link" dialog. I don't know if this behaviour is desirable.

Things to remember:

• Consider regressions:
  • Test that you can still successfully enter an external link to another website (could be anything like http://duckduckgo.com)
  • Test you can still enter an internal link (e.g. enter just the title of another page on the same wiki like Polar_bear)
• If possible, compare the behaviour of the "Insert link" dialog now to an earlier version. I think you can only do this if you set it up locally.
  • I put instructions how to install it locally here. After you have installed it locally, to get the older version of the software, do:
    • cd extensions/WikiEditor
    • git checkout fd74287b2f234ca33f7af8a227dd4b0c51d2a7b5
• Experiment with different ways of interacting with the dialog, such as pressing the enter key to submit.
• I have found some inconsistency in the behaviour of the "Insert link" dialog when using it to add multiple links in the same session.
  • Try repeating adding a link several times in a row and see if the outcome is the same each time. (For an example of a bug like this see T297371)
  • Try closing the dialog and reopening it. It normally returns to the same state it was in when you closed it.

(I have centralised some of these ideas here: Things to consider when testing)

Change 745127 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Set link type radio when confirming looks-like internal

https://gerrit.wikimedia.org/r/745127

Confirmed that user is able to insert link as internal and also verified above QA notes works as expected

Hiya -- I'm the one who initially reported this issue and I just used it today and it's better (hooray!) still not working as expected. The expectation is: if I enter a Wikipedia URL, and the tool asks me if I want to change it to an internal link, it does not also change the radio button to "internal link" if I answer in the affirmative. So as a result the link it includes is invalid, just http://PAGENAME (also shouldn't that be https?). Here's a few screenshots.... The previous behavior was that when you said "Yes I want an internal link" the tool would also change the radio button. I don't mind this, I can obviously click a button, but I think the expected result is that the tool would change this button. Thank you.

In T295517#7602478, @Jessamyn wrote:

Hiya...

@Jessamyn Thanks for following up on this.

Hmmm, this is not the behaviour I see. Which wiki are you using?

I think this is the same as the bug I reported in T295517#7552310, which I thought had been fixed by T295517#7584028.

Perhaps the wiki is using the older version of WikiEditor which does not have that fix.

The only other thing I can think of is that perhaps your browser has cached the previous Javascript, which has this bug. Just to check, would you be able to hard-refresh the page, clear your browser cache or use a different browser? Thanks.

In T295517#7604104, @dom_walden wrote:

In T295517#7602478, @Jessamyn wrote:

Hiya...

@Jessamyn Thanks for following up on this.

Hmmm, this is not the behaviour I see. Which wiki are you using?

Thank you. I am using English Wikipedia and the old school editor. If I switch to a different browser, I get the expected behavior, so I'll figure out if it's an add-on or some other caching that is causing this. Thank you for letting me know, problem is clearly on my end.

This does sound like it could be a caching issue. But @Jessamyn if you do see this error persisting in the original browser (which are the two browsers you're using, by the way?), please let us know.

Will do. I'm using Firefox (where I seem to see the caching issue) and Brave (where I do not and it functions correctly).