Page MenuHomePhabricator
Create Task
Maniphest T295544

Long filenames break save dialog layout
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Sgs
Authored By
kostajh
Nov 11 2021, 11:56 AM
Tags
Referenced Files
F34752326: Screenshot_20211117-104431_Samsung Internet.jpg
Nov 17 2021, 6:48 PM
F34749432: Screen Shot 2021-11-15 at 5.32.36 PM.png
Nov 16 2021, 1:36 AM
F34741999: image.png
Nov 11 2021, 12:14 PM
F34741978: image.png
Nov 11 2021, 11:56 AM
Subscribers
Aklapper
Etonkovidova
kostajh
RHo

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enter the save dialog for a suggestion with a long filename

What happens?:

image.png (388×882 px, 132 KB)

The image icon goes above the file name, and the "check" or "reject" icon is out of the viewport entirely

What should have happened instead?:

The image icon should stay left aligned, and the filename should wrap, allowing the check/reject icon to be visible.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

SubjectRepoBranchLines +/-
Avoid long filenames break save dialog layoutmediawiki/extensions/GrowthExperimentsmaster+10 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedMMiller_WMFT285587 [EPIC] "Add an image" Iteration 1
 ResolvedBUG REPORTSgsT295544 Long filenames break save dialog layout

Event Timeline

kostajh created this task.Nov 11 2021, 11:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2021, 11:56 AM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 11 2021, 11:56 AM
kostajh added a subscriber: RHo.

@RHo could you check my "what should have happened" description to make sure that I've got that right, please?

RHo added a comment.Nov 11 2021, 12:14 PM
In T295544#7498461, @kostajh wrote:

@RHo could you check my "what should have happened" description to make sure that I've got that right, please?

Hi @kostajh - thanks for noticing this. I've updated the figma spec to show an example of what should happen with the name is long and needs to wrap. I think it is basically what you've written:

image.png (890×1 px, 331 KB)

Sgs claimed this task.Nov 11 2021, 1:02 PM
kostajh triaged this task as High priority.Nov 11 2021, 2:09 PM
Sgs moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 12 2021, 10:36 AM
gerritbot added a comment.Nov 15 2021, 4:02 PM

Change 738955 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Avoid long filenames break save dialog layout

https://gerrit.wikimedia.org/r/738955

gerritbot added a project: Patch-For-Review.Nov 15 2021, 4:02 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 15 2021, 4:11 PM
gerritbot added a comment.Nov 15 2021, 5:53 PM

Change 738955 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Avoid long filenames break save dialog layout

https://gerrit.wikimedia.org/r/738955

• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 15 2021, 5:53 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 15 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 15 2021, 6:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 16 2021, 1:36 AM
Etonkovidova subscribed.

Checked in betalabs - works as expected.

In T295544#7498483, @RHo wrote:
In T295544#7498461, @kostajh wrote:

@RHo could you check my "what should have happened" description to make sure that I've got that right, please?

Hi @kostajh - thanks for noticing this. I've updated the figma spec to show an example of what should happen with the name is long and needs to wrap. I think it is basically what you've written:

image.png (890×1 px, 331 KB)

@RHo The file name in your mockup is displayed as it would be on a File page on commons. Probably it'd make sense to change the file name display to a commons File page title (I mentioned it already in one of my comments)?

image.png (388×882 px, 132 KB)
Screen Shot 2021-11-15 at 5.32.36 PM.png (329×909 px, 46 KB)
RHo mentioned this in T295886: Add image: Image file name should be displayed as a Commons File page title .Nov 17 2021, 2:03 PM
In T295544#7505631, @Etonkovidova wrote:

Checked in betalabs - works as expected.

In T295544#7498483, @RHo wrote:
In T295544#7498461, @kostajh wrote:

@RHo could you check my "what should have happened" description to make sure that I've got that right, please?

Hi @kostajh - thanks for noticing this. I've updated the figma spec to show an example of what should happen with the name is long and needs to wrap. I think it is basically what you've written:

image.png (890×1 px, 331 KB)

@RHo The file name in your mockup is displayed as it would be on a File page on commons. Probably it'd make sense to change the file name display to a commons File page title (I mentioned it already in one of my comments)?

image.png (388×882 px, 132 KB)
Screen Shot 2021-11-15 at 5.32.36 PM.png (329×909 px, 46 KB)

Ah yes I agree. Filed as T295886 - thanks for the prompt!

Etonkovidova closed this task as Resolved.Nov 17 2021, 6:48 PM

Checked on testwiki wmf.9 - looks as expected:

Screenshot_20211117-104431_Samsung Internet.jpg (2×1 px, 245 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL