Page MenuHomePhabricator
Create Task
Maniphest T295546

Read api app key and jwtSecret from a k8s secret created from terraform
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently the app key and jwtSecret are hardcoded in a values file.
This was identified while looking an initiative 4
https://github.com/wmde/wbaas-deploy/pull/96#discussion_r746051176

Acceptance Criteria

  • These values come from a secret
  • The secret is created using terraform
  • The values used on wikibase.dev are rotated

Event Timeline

Addshore created this task.Nov 11 2021, 12:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2021, 12:45 PM
Addshore triaged this task as Low priority.Nov 11 2021, 12:45 PM
Addshore added a project: Technical-Debt.
Addshore set the point value for this task to 1.Nov 11 2021, 12:48 PM
Deniz_WMDE added a comment.Nov 17 2021, 9:08 AM

This PR should solve AC The secret is created using terraform https://github.com/wmde/wbaas-deploy/pull/99

Deniz_WMDE updated the task description. (Show Details)Nov 17 2021, 9:08 AM
Deniz_WMDE added a comment.Nov 17 2021, 12:43 PM

And this PR should solve AC These values come from a secret https://github.com/wbstack/charts/pull/34

Deniz_WMDE updated the task description. (Show Details)Nov 17 2021, 12:43 PM
Deniz_WMDE updated the task description. (Show Details)

And both together will effectively solve the third one as soon as the changes are applied to staging, which creates the secrets and uses them.

Jakob_WMDE moved this task from Doing to Review on the Wikibase Cloud board.Nov 17 2021, 1:20 PM
• Samantha_Alipio_WMDE edited projects, added Wikibase Federated Properties Deployment (Iteration Zero); removed Wikibase Cloud.Nov 17 2021, 1:46 PM
• Samantha_Alipio_WMDE moved this task from Sprint Backlog to Review on the Wikibase Federated Properties Deployment (Iteration Zero) board.
Deniz_WMDE added a comment.Nov 17 2021, 1:47 PM

note that the secret formats will change with this as explained here https://github.com/wmde/wbaas-deploy/pull/99#issuecomment-971554002

Deniz_WMDE moved this task from Review to Deploy to Staging on the Wikibase Federated Properties Deployment (Iteration Zero) board.Nov 18 2021, 1:51 PM
Deniz_WMDE moved this task from Deploy to Staging to Done on the Wikibase Federated Properties Deployment (Iteration Zero) board.Nov 18 2021, 3:33 PM
Deniz_WMDE updated the task description. (Show Details)

Applied to staging

Addshore closed this task as Resolved.Dec 7 2021, 1:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL