Page MenuHomePhabricator

Rename existing Kubernetes node pools in terraform
Closed, ResolvedPublic1 Estimated Story Points

Description

The names of Kubernetes node pools in terraform are global names in the state
currently our two node pools for our second cluster have generic names like medium and standard
these should probably include the name of the cluster that they relate to to avoid conflicting with other node pools for other clusters

this was identified while initially looking at initiative 4
https://github.com/wmde/wbaas-deploy/pull/96#discussion_r746053043

Event Timeline

Addshore set the point value for this task to 1.
dang moved this task from Backlog to Doing on the Wikibase.cloud board.

https://github.com/wmde/wbaas-deploy/pull/129

Here's the PR for this task. Anyone has a better idea for renaming node pools please stand up. I think having both - and _ in a string like wbaas-2_google_container_node_pool is kinda awkward...

Looks like a good start! Left a comment on the PR about how the resource definitions need to look.

No objection to the naming.