Page MenuHomePhabricator

Support single HTML tags in mediawiki.jqueryMsg
Closed, ResolvedPublicFeature

Description

Currently, mediawiki.jqueryMsg doesn't support single HTML tags (tags like <meta> which don't have a closing part):

mw.messages.set( 'test', 'a<br>b' );
mw.message( 'test' ).parse(); // 'a&lt;br&gt;b'

Use of <br> in frontend messages would be handy.

Looking at the code, it doesn't seem super hard to fix, we'd just have to check against the single-tag list when a closing tag is not found.

Event Timeline

Change #1203448 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1203448

To test whether this change breaks anything, I've run core's en.json through jqueryMsg both with and without my patch, and when comparing the two, there were no changes. Meanwhile, <br> and the other two tags now work fine for me.
Code for testing:

(function() {
  const jQueryParse = function(input, params) {
    mw.messages.set('foo', input);
    return mw.message('foo', params).parse();
  };
  $.getJSON("https://raw.githubusercontent.com/wikimedia/mediawiki/refs/heads/master/languages/i18n/en.json").done((data) => {
    delete data["@metadata"];
    const parsed = {};
    for (const [key, value] of Object.entries(data)) {
      parsed[key] = jQueryParse(value);
    }
    console.log(JSON.stringify(parsed));
  });
})();

Change #1203448 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1203448

(I'm gonna boldly assume that this is done following the patch being merged; please reopen if there's anything left to do! cc @SomeRandomDeveloper)

Change #1210641 had a related patch set uploaded (by SBassett; author: SomeRandomDeveloper):

[mediawiki/core@REL1_45] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1210641

Change #1210641 merged by jenkins-bot:

[mediawiki/core@REL1_45] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1210641

Change #1211251 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@REL1_45] RELEASE-NOTES-1.45: Add entry for jqueryMsg self-closing tag support

https://gerrit.wikimedia.org/r/1211251

Change #1211251 abandoned by SomeRandomDeveloper:

[mediawiki/core@REL1_45] RELEASE-NOTES-1.45: Add entry for jqueryMsg self-closing tag support

Reason:

wrong branch for the initial patch; will push a new one to master and cherry-pick it to REl1_45 instead

https://gerrit.wikimedia.org/r/1211251

Change #1211258 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] RELEASE-NOTES-1.45: Add entry for jqueryMsg self-closing tag support

https://gerrit.wikimedia.org/r/1211258

Change #1211259 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@REL1_45] RELEASE-NOTES-1.45: Add entry for jqueryMsg self-closing tag support

https://gerrit.wikimedia.org/r/1211259

Change #1211258 merged by jenkins-bot:

[mediawiki/core@master] RELEASE-NOTES-1.45: Add entry for jqueryMsg self-closing tag support

https://gerrit.wikimedia.org/r/1211258

Change #1211259 merged by jenkins-bot:

[mediawiki/core@REL1_45] RELEASE-NOTES-1.45: Add entry for jqueryMsg self-closing tag support

https://gerrit.wikimedia.org/r/1211259

Change #1216650 had a related patch set uploaded (by Reedy; author: SomeRandomDeveloper):

[mediawiki/core@REL1_44] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1216650

Change #1216651 had a related patch set uploaded (by Reedy; author: SomeRandomDeveloper):

[mediawiki/core@REL1_43] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1216651

Change #1216650 merged by jenkins-bot:

[mediawiki/core@REL1_44] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1216650

Change #1216651 merged by jenkins-bot:

[mediawiki/core@REL1_43] mediawiki.jqueryMsg: Support self-closing HTML tags

https://gerrit.wikimedia.org/r/1216651