Page MenuHomePhabricator

Patch for wfgettype()
Closed, DeclinedPublic

Description

Author: pompo500

Description:
Copypaste from email:

img_auth.php

There is a mention in the comment that this could be probably done better.
You're right. I rewrote the function and it's now like 10x faster, because
regular expressions are slow and now it uses an indexed array. Which is
lightning fast.

http://pompo500.xs.fi/tmp/wfgettype.phps


Version: unspecified
Severity: normal

Details

Reference
bz956

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 7:03 PM
bzimport set Reference to bz956.
bzimport added a subscriber: Unknown Object (MLST).

pompo500 wrote:

The new proposed wfgettype() function

Attached:

I should note that the performance gain is actually very slight; my
benchmarks show only about a 2% speed improvement in load time
of img_auth.php as a whole (with Turck MMCache enabled to reduce
the PHP compilation overhead). That's moving from 30 milliseconds
per hit to 29 milliseconds.

Diffusion changed the task status from Declined to Resolved by committing Unknown Object (Diffusion Commit).Mar 4 2015, 8:20 AM
Diffusion added a commit: Unknown Object (Diffusion Commit).
Aklapper changed the task status from Resolved to Declined.Mar 4 2015, 5:45 PM
Aklapper claimed this task.