Page MenuHomePhabricator
Create Task
Maniphest T295628

linkrecommendation-internal logs appear to be multiline json
Closed, ResolvedPublic
Actions

Description

This makes the logs fairly unintelligible: https://logstash.wikimedia.org/goto/bf5ed39874f5789a31f4151af12b4315

Details

SubjectRepoBranchLines +/-
linkrecommendation: Bump versionoperations/deployment-chartsmaster+1 -1
remove indent parameterresearch/mwaddlinkmain+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

colewhite created this task.Nov 13 2021, 12:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2021, 12:59 AM
colewhite added a project: Growth-Team.Nov 15 2021, 10:57 PM
Tgr subscribed.Nov 17 2021, 2:04 AM

The service uses the json-logging library which in turn uses plain json.dumps as serializer, which in theory shouldn't be multiline. Not sure where that goes wrong.

Tgr added a project: Add-Link.Nov 17 2021, 2:05 AM
Tgr moved this task from Inbox to Upcoming Work on the Growth-Team board.Nov 17 2021, 2:23 AM
gerritbot added a comment.Nov 17 2021, 4:44 PM

Change 739571 had a related patch set uploaded (by Cwhite; author: Cwhite):

[research/mwaddlink@main] remove indent parameter

https://gerrit.wikimedia.org/r/739571

gerritbot added a project: Patch-For-Review.Nov 17 2021, 4:44 PM
colewhite added a parent task: T295935: Average logging ingest has doubled over the last 90 days.Nov 17 2021, 9:39 PM
gerritbot added a comment.Nov 23 2021, 8:16 AM

Change 739571 merged by jenkins-bot:

[research/mwaddlink@main] remove indent parameter

https://gerrit.wikimedia.org/r/739571

colewhite mentioned this in rRMWAcff8162dd72b: remove indent parameter.Nov 23 2021, 8:49 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 23 2021, 9:10 AM
gerritbot added a comment.Nov 23 2021, 9:44 AM

Change 740788 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/deployment-charts@master] linkrecommendation: Bump version

https://gerrit.wikimedia.org/r/740788

gerritbot added a project: Patch-For-Review.Nov 23 2021, 9:44 AM
gerritbot added a comment.Nov 23 2021, 9:51 AM

Change 740788 merged by jenkins-bot:

[operations/deployment-charts@master] linkrecommendation: Bump version

https://gerrit.wikimedia.org/r/740788

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2021, 10:10 AM
kostajh closed this task as Resolved.Nov 23 2021, 2:15 PM
kostajh claimed this task.
kostajh subscribed.

@colewhite I just deployed the updated image that includes this patch. Please reopen if there are any issues, and thanks for the patch!

colewhite added a comment.Nov 23 2021, 8:16 PM

Thanks @kostajh! I see it reduced the number of linkrecommendation events logged by 84% 🎉

Screenshot from 2021-11-23 20-11-42.png (257×1 px, 31 KB)

colewhite added a subtask: T296334: Make linkrecommendation service logging more useful.Nov 23 2021, 8:24 PM
Urbanecm_WMF changed the status of subtask T296334: Make linkrecommendation service logging more useful from Open to In Progress.Jan 31 2022, 11:33 AM
kostajh changed the status of subtask T296334: Make linkrecommendation service logging more useful from In Progress to Open.Mar 2 2022, 1:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL