Page MenuHomePhabricator

Title of the deleted revision should be shown in message "missing-revision"
Open, MediumPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Assume a page with title "Foo" has revision (oldid) "1234"
  • Delete page Foo
  • Visit /w/index.php?oldid=1234

What happens?:
We got a notice said this revision is deleted. However, the notice is actually partial correct: this revision does not belongs to page "Main Page"!

image.png (259×959 px, 32 KB)

What should have happened instead?:
It should display the actual title associate with this deleted revision.
For this example, it should be like "The revision #2272 of the page named "MediaWiki:Uploadwarning" does not exist".

Request:
{
	"action": "query",
	"format": "json",
	"prop": "revisions",
	"revids": "2272"
}
Response:
{
    "batchcomplete": "",
    "query": {
        "pages": {
            "-1": {
                "ns": 8,
                "title": "MediaWiki:Uploadwarning",
                "missing": "",
                "known": ""
            }
        }
    }
}

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
1.38.0-wmf.26 (91f40bd)

Event Timeline

Show the contents of a deleted revision when accessing that version.

I fail to understand - isn't the concept of deletion exactly NOT to show the content that was deleted? :) Which page to show what on? Which parts of this ticket are about changes to Special:Undelete, which parts about Special:PermaLink? What do you expect to happen on which page?

For a page that performs a revision deletion, the following prompt will appear when accessing a certain oldid. At this point, sysop can still view the contents of this historical revision.

One of the revisions of this diff has been deleted. Details can be found in the deletion log. You can still view this diff if you wish to proceed.

However, if all revisions of a page have been deleted, no one can easily view the history when accessing an oldid of the page. And the purpose of this proposal is to make the prompt for the latter case more friendly, so that sysop can easily lookup that oldid.

Content under "Also, the deleted revision..." is for Special:Undelete, and the content above belongs to Special:PermaLink. I can split this ticket if needed.

Stang renamed this task from More friendly deleted revision lookup to Title of the deleted revision should be shown in message "missing-revision".Mar 19 2022, 1:34 AM
Stang updated the task description. (Show Details)
Stang changed the subtype of this task from "Feature Request" to "Bug Report".

Make it more accurate.

Change 772017 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/core@master] Replace "missing-revision" message if a revision belongs to a deleted page

https://gerrit.wikimedia.org/r/772017

Stang triaged this task as Medium priority.Mar 23 2022, 5:22 PM

Change 786733 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/core@master] Fix "deletion log" link in message "difference-missing-revision"

https://gerrit.wikimedia.org/r/786733