Page MenuHomePhabricator

When validating a ZObject against a schema, every Z9/Reference is considered valid
Closed, ResolvedPublicBUG REPORT

Description

In the current version of the function-schemata, most Z4/Type definitions are written in a way that accepts a literal object or a reference to the type. However, the system is accepting any reference instead of only the ones to the same type. For example, if the following object is validated against a Z5/Error validator, it is being considered valid:

{
    "Z1K1": "Z9",
    "Z9K1": "Z10"
}

The problem can be solved by including a Z9_ZX subdefinition for every other type X instead of referencing the general Z9 definition. This already exists for the definition of the Z1K1 key of each type.

Event Timeline

arthurlorenzi updated the task description. (Show Details)
arthurlorenzi updated the task description. (Show Details)

Change 742437 had a related patch set uploaded (by Arthur Lorenzi; author: Arthur Lorenzi):

[mediawiki/services/function-schemata@master] Including literal validators for ZObjects

https://gerrit.wikimedia.org/r/742437

Change 742439 had a related patch set uploaded (by Arthur Lorenzi; author: Arthur Lorenzi):

[mediawiki/services/function-orchestrator@master] Using literal validators in orchestrator

https://gerrit.wikimedia.org/r/742439

Change 742437 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Including literal validators for ZObjects

https://gerrit.wikimedia.org/r/742437

Change 744083 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744083

Change 744082 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744082

Change 744084 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744084

DVrandecic raised the priority of this task from Low to High.

Change 745566 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/745566

Change 744084 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744084

Change 745566 abandoned by Jforrester:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

Reason:

https://gerrit.wikimedia.org/r/745566

Change 744082 merged by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744082

Change 744083 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744083

Change 742439 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Using literal validators in orchestrator

https://gerrit.wikimedia.org/r/742439