Description

per @RHo feedback in "Add an image" testing

Suggested edits module task type info icon should appear after last word of the task type (not orphaned as shown below)

The issue is present on both iOS (iPhone 6s, 375x675) and Android (Samsung Galaxy S8 360x740 (Note: I did not see the issue i present in browser mobile emulator).
(the screenshot is from Android)

Screenshot_20211115-124442_Chrome.jpg (2×1 px, 321 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Suggested Edits: Prevent the task type info icon from being orphaned	mediawiki/extensions/GrowthExperiments	master	+19 -0

Customize query in gerrit

Related Objects

Mentioned In: T298215: Suggested edits: icon is misaligned in the task description tooltip

Event Timeline

Etonkovidova created this task.Nov 15 2021, 8:48 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 15 2021, 8:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• mewoph claimed this task.Nov 15 2021, 10:43 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 739022 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Prevent the task type info icon from being orphaned

https://gerrit.wikimedia.org/r/739022

gerritbot added a project: Patch-For-Review.Nov 15 2021, 11:46 PM

Before:

Screen Shot 2021-11-15 at 3.35.16 PM.png (310×636 px, 38 KB)

After:

Screen Shot 2021-11-15 at 3.33.54 PM.png (296×580 px, 37 KB)

I see different behavior:

I think it's just a rounding error, the image is very slightly larger than 36px so the padding should be 1px more.

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 22 2021, 2:21 AM

Change 739022 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Prevent the task type info icon from being orphaned

https://gerrit.wikimedia.org/r/739022

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 22 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2021, 3:10 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 7 2021, 1:18 AM

Etonkovidova updated the task description. (Show Details)Dec 10 2021, 12:43 AM

Checked on eswiki wmf.12 - the fix is in place:

Screen Shot 2021-12-09 at 4.52.47 PM.png (920×738 px, 106 KB)

Screen Shot 2021-12-09 at 4.52.36 PM.png (910×760 px, 124 KB)

• mewoph mentioned this in T298215: Suggested edits: icon is misaligned in the task description tooltip.Dec 22 2021, 9:15 PM

	F34873657: Screen Shot 2021-12-09 at 4.52.47 PM.png
	Dec 10 2021, 12:56 AM

	F34873648: Screen Shot 2021-12-09 at 4.52.36 PM.png
	Dec 10 2021, 12:56 AM

	F34749313: Screen Shot 2021-11-15 at 3.35.16 PM.png
	Nov 15 2021, 11:46 PM

	F34749315: Screen Shot 2021-11-15 at 3.33.54 PM.png
	Nov 15 2021, 11:46 PM

	F34749139: Screenshot_20211115-124442_Chrome.jpg
	Nov 15 2021, 8:48 PM

Suggested edits module task type info icon should not be orphanedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Suggested edits module task type info icon should not be orphaned
Closed, ResolvedPublic
Actions