Page MenuHomePhabricator

Resolve overlapping menus (echo menus, user menu, ULS)
Closed, ResolvedPublic

Description

Description

As a general rule there should only be one menu open at a time. So when you open a menu, if another menu is currently open it should close. This seems to work properly for the new User menu and the new ULS, and also seems to work properly for the two echo menus (Notifications and Alerts), but it doesn't seem to be working properly for the echo menus and the User menu/ULS.

Acceptance criteria

  • When Echo icons are clicked, do not stop propagation.

QA

  • Click language button to open ULS dialog
  • Click Echo button

Expected: ULS should close.

Developer notes

Echo should not call stopPropagation

QA Results - Beta

ACStatusDetails
1T295796#7759059

Event Timeline

ovasileva triaged this task as Medium priority.Nov 17 2021, 4:39 PM
ovasileva added a subscriber: SCherukuwada.

Discussed this in our product planning meeting today. @SCherukuwada will take on analysis for this one. Note that depending on the outcome and where the issue lies, we might ask the growth team to take a look as well.

Having reproduced and tested this somewhat, it looks like clicking on the Alerts or Notices buttons does not hide the ULS menu but clicking on the User Menu does.

It has nothing to do with ULS. I can reproduce the same behaviour just clicking on the Alerts and then clicking on the user menu. There's some event that's being blocked or not sent by clicking on Alerts and Notices that the User Menu and ULS rely on to hide themselves.

Screenshot from 2021-11-18 11-32-23.png (396×565 px, 64 KB)

@SCherukuwada the user-menu and ULS hide themselves using the same mechanism, the "checkbox-hack" from mediawiki-core. resources/src/mediawiki.page.ready/checkboxHack.js so that's the event (either from click or focusin) that isn't being fired.

kostajh added a subscriber: kostajh.

@ovasileva @SCherukuwada is this something your team is going to work on? I'm moving this to Triaged as I don't think it's something that Growth will be able to prioritize in the short-to-medium term, though we could help with code review / QA if someone writes a patch.

Change 763578 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Clicking Echo badge should close ULS dialog

https://gerrit.wikimedia.org/r/763578

Clicking outside ULS should hide it. I believe this is not an issue with z-index, but the fact that clicks on Echo call stopPropagation which prevents ULS from hiding which the above patch fixes.

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6f4270889d/w/

Change 763578 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Clicking Echo badge should close ULS dialog

https://gerrit.wikimedia.org/r/763578

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Click language button to open ULS dialog
Click Echo button
✅ AC1: Expected: ULS should close.

Screen Recording 2022-03-07 at 6.41.05 PM.mov.gif (650×1 px, 795 KB)

Screen Recording 2022-03-07 at 6.39.43 PM.mov.gif (650×1 px, 878 KB)

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/6f4270889d/w/