Page MenuHomePhabricator
Create Task
Maniphest T295796

Resolve overlapping menus (echo menus, user menu, ULS)
Closed, ResolvedPublic
Actions

Assigned To
Edtadros
Authored By
• alexhollender_WMF
Nov 16 2021, 6:13 PM
Tags
Referenced Files
F34983516: Screen Recording 2022-03-07 at 6.41.05 PM.mov.gif
Mar 8 2022, 2:43 AM
F34983517: Screen Recording 2022-03-07 at 6.39.43 PM.mov.gif
Mar 8 2022, 2:43 AM
F34753706: Screenshot from 2021-11-18 11-32-23.png
Nov 18 2021, 10:35 AM
F34750505: overlapping menus.webm
Nov 16 2021, 6:13 PM
Subscribers
Aklapper
• alexhollender_WMF
Jdlrobson
Jdrewniak
kostajh
ovasileva
SCherukuwada
Volker_E

Description

Description

As a general rule there should only be one menu open at a time. So when you open a menu, if another menu is currently open it should close. This seems to work properly for the new User menu and the new ULS, and also seems to work properly for the two echo menus (Notifications and Alerts), but it doesn't seem to be working properly for the echo menus and the User menu/ULS.

Acceptance criteria

  • When Echo icons are clicked, do not stop propagation.

QA

  • Click language button to open ULS dialog
  • Click Echo button

Expected: ULS should close.

Developer notes

Echo should not call stopPropagation

QA Results - Beta

ACStatusDetails
1✅T295796#7759059

Details

SubjectRepoBranchLines +/-
Clicking Echo badge should close ULS dialogmediawiki/extensions/Echomaster+17 -3
Customize query in gerrit

Event Timeline

• alexhollender_WMF created this task.Nov 16 2021, 6:13 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 16 2021, 6:13 PM
Tgr moved this task from Inbox to Needs Discussion on the Growth-Team board.Nov 17 2021, 2:21 AM
ovasileva triaged this task as Medium priority.Nov 17 2021, 4:39 PM
ovasileva assigned this task to SCherukuwada.Nov 17 2021, 6:47 PM
ovasileva added a subscriber: SCherukuwada.

Discussed this in our product planning meeting today. @SCherukuwada will take on analysis for this one. Note that depending on the outcome and where the issue lies, we might ask the growth team to take a look as well.

SCherukuwada added a comment.Nov 18 2021, 10:10 AM

Having reproduced and tested this somewhat, it looks like clicking on the Alerts or Notices buttons does not hide the ULS menu but clicking on the User Menu does.

SCherukuwada added a comment.Nov 18 2021, 10:35 AM

It has nothing to do with ULS. I can reproduce the same behaviour just clicking on the Alerts and then clicking on the user menu. There's some event that's being blocked or not sent by clicking on Alerts and Notices that the User Menu and ULS rely on to hide themselves.

Screenshot from 2021-11-18 11-32-23.png (396×565 px, 64 KB)

Jdrewniak subscribed.Nov 18 2021, 5:54 PM

@SCherukuwada the user-menu and ULS hide themselves using the same mechanism, the "checkbox-hack" from mediawiki-core. resources/src/mediawiki.page.ready/checkboxHack.js so that's the event (either from click or focusin) that isn't being fired.

kostajh moved this task from Needs Discussion to Triaged on the Growth-Team board.Dec 9 2021, 1:59 PM
kostajh subscribed.

@ovasileva @SCherukuwada is this something your team is going to work on? I'm moving this to Triaged as I don't think it's something that Growth will be able to prioritize in the short-to-medium term, though we could help with code review / QA if someone writes a patch.

SCherukuwada added a comment.Dec 9 2021, 2:46 PM

We'll take care of this.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Dec 15 2021, 10:48 PM
Jdlrobson moved this task from Incoming to Header, Userlinks and logos on the Desktop Improvements (Vector 2022) board.Dec 23 2021, 7:55 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.Jan 6 2022, 12:23 PM
Jdlrobson updated the task description. (Show Details)Feb 17 2022, 5:46 PM
gerritbot added a comment.Feb 17 2022, 5:47 PM

Change 763578 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Clicking Echo badge should close ULS dialog

https://gerrit.wikimedia.org/r/763578

gerritbot added a project: Patch-For-Review.Feb 17 2022, 5:47 PM
Jdlrobson added a comment.Feb 17 2022, 5:47 PM

Clicking outside ULS should hide it. I believe this is not an issue with z-index, but the fact that clicks on Echo call stopPropagation which prevents ULS from hiding which the above patch fixes.

Jdlrobson removed SCherukuwada as the assignee of this task.Feb 17 2022, 5:47 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 23 2022, 4:20 PM
PatchDemoBot added a comment.Mar 4 2022, 10:23 PM

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6f4270889d/w/

gerritbot added a comment.Mar 5 2022, 6:09 AM

Change 763578 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Clicking Echo badge should close ULS dialog

https://gerrit.wikimedia.org/r/763578

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2022, 6:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 5 2022, 7:00 AM
Jdlrobson assigned this task to Edtadros.Mar 7 2022, 6:43 PM
Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Ready for Signoff to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 8 2022, 2:43 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Click language button to open ULS dialog
Click Echo button
✅ AC1: Expected: ULS should close.

Screen Recording 2022-03-07 at 6.41.05 PM.mov.gif (650×1 px, 795 KB)

Screen Recording 2022-03-07 at 6.39.43 PM.mov.gif (650×1 px, 878 KB)

Edtadros updated the task description. (Show Details)Mar 8 2022, 2:44 AM
ovasileva closed this task as Resolved.Mar 8 2022, 10:20 AM

Looks good!

PatchDemoBot added a comment.Mar 17 2022, 12:02 AM

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/6f4270889d/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL