Page MenuHomePhabricator
Create Task
Maniphest T295810

Add image - italicized text on first overlay screen is too big
Closed, ResolvedPublic
Actions

Description

per @MMiller_WMF feedback in "Add an image" testing

Italicised smaller UI text in Base20 Base30: Images come from Wikimedia Commons, a collection of freely licensed images used by Wikipedia.

Screen Shot 2021-11-16 at 7.02.35 AM.png (1×756 px, 182 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add an image: add subtext style for onboardingmediawiki/extensions/GrowthExperimentsmaster+12 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Nov 16 2021, 7:39 PM
Etonkovidova mentioned this in T292092: Add an image: overlay onboarding.
gerritbot added a comment.Nov 16 2021, 11:04 PM

Change 739368 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: add subtext style for onboarding

https://gerrit.wikimedia.org/r/739368

gerritbot added a project: Patch-For-Review.Nov 16 2021, 11:04 PM
• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 16 2021, 11:05 PM

With latest changes:

Screen Shot 2021-11-16 at 3.00.28 PM.png (1×752 px, 175 KB)

gerritbot added a comment.Nov 19 2021, 1:37 PM

Change 739368 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: add subtext style for onboarding

https://gerrit.wikimedia.org/r/739368

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 19 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 19 2021, 2:10 PM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 22 2021, 10:08 PM
Etonkovidova added a comment.Nov 24 2021, 1:04 AM

@mewoph - is it supposed to be in Base20 (https://design.wikimedia.org/style-guide/visual-style_colors.html shows a different color)? There was another mention of Base20 in https://phabricator.wikimedia.org/T292092.

RHo updated the task description. (Show Details)Nov 24 2021, 10:27 AM
In T295810#7525427, @Etonkovidova wrote:

@mewoph - is it supposed to be in Base20 (https://design.wikimedia.org/style-guide/visual-style_colors.html shows a different color)? There was another mention of Base20 in https://phabricator.wikimedia.org/T292092.

Sorry @Etonkovidova and @mewoph - this was my error in copying the spec colour value, it's Base30 so the colour is correct.

Etonkovidova closed this task as Resolved.Nov 24 2021, 6:03 PM
In T295810#7525962, @RHo wrote:
In T295810#7525427, @Etonkovidova wrote:

@mewoph - is it supposed to be in Base20 (https://design.wikimedia.org/style-guide/visual-style_colors.html shows a different color)? There was another mention of Base20 in https://phabricator.wikimedia.org/T292092.

Sorry @Etonkovidova and @mewoph - this was my error in copying the spec colour value, it's Base30 so the colour is correct.

Thanks! Then the task is Resolved.

Urbanecm_WMF added a project: GrowthExperiments-NewcomerTasks.Jan 21 2026, 2:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits