Page MenuHomePhabricator

Add an image: always show the placeholder text when there's no input
Closed, ResolvedPublic

Description

An exception to the requirement "If they do anything that brings their focus outside the caption box, like opening image details, opening the caption onboarding, or tapping the inactive publish button, this triggers the red warning text." is if the user does not input any characters in the caption box and loses focus, in that case the caption input should still contain the placeholder text.

When there is no caption text (whether via the initial state or when the user entered and then deleted text), the placeholder should be shown. The validation warning should not be shown.

Event Timeline

Change 739585 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Don't show validation warnings when the caption is empty

https://gerrit.wikimedia.org/r/739585

Please add project tags as project tags, not as subscribers. Thanks.

Hi @RHo — to clarify, should this exception only apply to when the user hasn't entered anything at all or also when the user has entered something and then deleted resulting in an empty caption?

Hi @RHo — to clarify, should this exception only apply to when the user hasn't entered anything at all or also when the user has entered something and then deleted resulting in an empty caption?

Thanks for checking @mewoph - I think we should show the placeholder text whenever the input is empty.

mewoph renamed this task from Add an image: do not trigger validation if input=0 to Add an image: always show the placeholder text when there's no input.Nov 18 2021, 4:36 PM
mewoph updated the task description. (Show Details)

Thanks for the clarification @RHo! I updated the task title & description.

Change 739585 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Show placeholder text when the caption is empty

https://gerrit.wikimedia.org/r/739585