| RHo | |
| Nov 17 2021, 8:34 PM |
| F34907436: addimage_reject.gif | |
| Jan 4 2022, 7:06 PM |
| F34893898: VE_loading_state.png | |
| Dec 23 2021, 1:07 PM |
| F34886906: addimage_reject_postedit.gif | |
| Dec 17 2021, 12:03 AM |
| F34876811: image.png | |
| Dec 10 2021, 10:40 AM |
| F34876806: image.png | |
| Dec 10 2021, 10:40 AM |
| F34872599: saveDialog_loading.jpg | |
| Dec 9 2021, 9:54 PM |
| F34872575: Screen Shot 2021-12-09 at 1.44.21 PM.png | |
| Dec 9 2021, 9:54 PM |
Follow up from iteration 1 task T290046, the intended behaviour after a user rejects an image is that they should be shown the post-edit dialog.
See figma spec: https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task?node-id=3018%3A9307
Note: @MRaishWMF and @Dyolf77_WMF noted that having to 'confirm' the rejection as an added step was a pain point/unexpected during pre-release testing with arwiki newcomers on in Week 47.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T285587 [EPIC] "Add an image" Iteration 1 | |||
| Resolved | DMburugu | T289823 Add an image: frontend tasks for initial release | |||
| Resolved | Tgr | T290046 Add an image: rejection dialog | |||
| Open | None | T293711 [EPIC] "Add an image" Iteration 2 | |||
| Resolved | • mewoph | T295929 Add an image: After rejecting an image, the user should be taken directly to the post-edit dialog |
Hi @RHo, I wanted to confirm the interactions for this change:
Hi @RHo, I wanted to confirm the interactions for this change:
- Should the user be taken directly to the post-edit dialog right after they submit the rejection reason (no way to undo the reason)?
Hi @mewoph - yes that's correct.
- Where should the loading state be for this change (if any)? Even though no edits are made, there's still an API call to save the rejection so we should ensure that the request went through. Currently this is handled by the loading state of the save dialog.
Ahh I see. Could we use the toolbar on mobile similar to when "loading" the image that's added?
Then when it's time for Desktop implementation, we would re-use the progress bar equivalent that is shown when switching between editors
Change 747979 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add an image: Save the rejection directly
@RHo A minor comment on the design, isn't a bit weird that the loading state text "Submitting..." appears under the gray overlay? It's definitely a minor issue but maybe we can improve it in the future.
When VE loads there's a similar "Loading..." state and the overlay only covers the edit area. I understand we don't want the buttons available neither because we don't don't want them to abandon the editor or change the mode while saving.
Yes that looks like a bug that should be fixed, as my design in the comment above has it showing over the overlay:
Hi @RHo, I wanted to confirm the interactions for this change:
- Should the user be taken directly to the post-edit dialog right after they submit the rejection reason (no way to undo the reason)?
Hi @mewoph - yes that's correct.
- Where should the loading state be for this change (if any)? Even though no edits are made, there's still an API call to save the rejection so we should ensure that the request went through. Currently this is handled by the loading state of the save dialog.
Ahh I see. Could we use the toolbar on mobile similar to when "loading" the image that's added?
Change 747979 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add an image: Save the rejection directly
Change 751486 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add an image: hide edit mode toggle and show toolbar when submitting rejection
Change 751486 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add an image: hide edit mode toggle and show toolbar when submitting rejection
