Page MenuHomePhabricator

Docker: use php image with php-ast in them (73 or 74)
Closed, ResolvedPublic

Description

Following T286677, PHP images php73 and php74 have php-ast installed.

This means that Phan can be used in Docker, which is extremely annoying to not have, as every change has to be round-tripped though Gerrit.

Event Timeline

Change 739763 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/core@master] Docker: use php74 images

https://gerrit.wikimedia.org/r/739763

This means that Phan can be used in Docker, which is extremely annoying to not have, as every change has to be round-tripped though Gerrit.

Note that this is not entirely the case, as there are two alternatives to waiting for jenkins to run phan:

  1. Run phan outside of docker, installing php-ast on your machine (or using another docker image for that)
  2. Pass the --allow-polyfill-parser option to the phan command to run it without php-ast. This is going to be slower and the output may be different, but better than nothing.

It's still extremely annoying that following the DEVELOPMENT.md file does not get you a system that can run the CI.

Also, I've never been able to run Phan externally, because it dies with thousands of PhanUndeclared* errors.

Change 821787 had a related patch set uploaded (by Krinkle; author: Jforrester):

[mediawiki/core@master] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/821787

Change 821787 merged by jenkins-bot:

[mediawiki/core@master] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/821787

Change 822164 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_38] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822164

Change 822165 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_37] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822165

Change 822386 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_35] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822386

Change 822386 abandoned by Jforrester:

[mediawiki/core@REL1_35] MediaWiki-Docker: Switch PHP images to PHP7.4

Reason:

We don't have a PHP7.4 + Apache + xdebug image to offer.

https://gerrit.wikimedia.org/r/822386

Change 822165 merged by jenkins-bot:

[mediawiki/core@REL1_37] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822165

Change 822164 merged by Jforrester:

[mediawiki/core@REL1_38] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822164

Change 739763 abandoned by Krinkle:

[mediawiki/core@master] Docker: use php74 images

Reason:

Superseded by https://gerrit.wikimedia.org/r/821787

https://gerrit.wikimedia.org/r/739763

Change 822386 restored by Kosta Harlan:

[mediawiki/core@REL1_35] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822386

Change 822386 merged by jenkins-bot:

[mediawiki/core@REL1_35] MediaWiki-Docker: Switch PHP images to PHP7.4

https://gerrit.wikimedia.org/r/822386