Page MenuHomePhabricator

Allow the source editor to work on old versions in mobile web view
Open, MediumPublicFeature

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • The editor loads in read-only mode (Viewing Source of ....)

What should have happened instead?:

  • The editor should allow editing and publishing.

Reported on enwiki at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Editng_an_older_version_of_an_article_not_possible_on_mobile%3F

Event Timeline

Note: editing and publishing if the Visual Editor is selected appears to be working.

This has always been that way apparently, probably because no one ever got around to implementing it properly (in a way that avoids random users saving old versions by accident more than the community would find acceptable).

src/mobile.editor.overlay/SourceEditorOverlay.js

this.readOnly = !!options.oldId; // If old revision, readOnly mode

It should probably check mw.config.get("wgMinervaReadOnly")) && mw.config.get("wgIsProbablyEditable") instead (which is what is used to show the proper icon in the article page).

Xaosflux renamed this task from Unable to use the source editor on old versions in mobile web view to Enabled the source editor to write on old versions in mobile web view.Nov 18 2021, 2:24 PM
Xaosflux renamed this task from Enabled the source editor to write on old versions in mobile web view to Allow the source editor to work old versions in mobile web view.
Xaosflux changed the subtype of this task from "Bug Report" to "Feature Request".
Xaosflux renamed this task from Allow the source editor to work old versions in mobile web view to Allow the source editor to work on old versions in mobile web view.Nov 18 2021, 2:26 PM

This has always been that way apparently, probably because no one ever got around to implementing it properly (in a way that avoids random users saving old versions by accident more than the community would find acceptable).

Thank you, I've changed this from a bug report to a feature request

cjming triaged this task as Medium priority.Nov 19 2021, 10:22 PM
cjming added a project: Web-Team-Backlog.
cjming added a subscriber: Web-Team-Backlog.

@cjming: Please don't add project tags as subscribers. Thanks!

Change 740377 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/MobileFrontend@master] Allow editing old revisions

https://gerrit.wikimedia.org/r/740377

Jdlrobson subscribed.

This is an editing team decision not web team decision since it concerns the editor.