🎬️ desktop-wpde-02 | Port another desktop banner to wikipedia.de | ⏰ Nov 19th
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	kai.nissen
	Nov 18 2021, 2:03 PM

Description

The variant banner of desktop-de-11 seems to perform well, so we want to change the test scope on wikipedia.de as soon as possible.

Acceptance Criteria

The control banner is the same as in desktop-wpde-01.
The variant banner is based on the variant banner of desktop-de-11, but using the copy of the control banner (including font weight definition).
The variant's banner height is increased to match the banner height of the control banner.

Event Timeline

kai.nissen created this task.Nov 18 2021, 2:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2021, 2:04 PM

kai.nissen moved this task from Backlog to Ready for Work on the WMDE-FUN-Funban-2021 board.Nov 18 2021, 2:20 PM

Maintenance_bot added a project: WMDE-FUN-Team.Nov 18 2021, 2:46 PM

CorinnaHillebrand_WMDE claimed this task.Nov 18 2021, 3:02 PM

CorinnaHillebrand_WMDE moved this task from Ready for Work to In Progress / Deployment (max. 3 tasks) on the WMDE-FUN-Funban-2021 board.

CorinnaHillebrand_WMDE reassigned this task from CorinnaHillebrand_WMDE to kai.nissen.Nov 19 2021, 12:40 PM

CorinnaHillebrand_WMDE moved this task from In Progress / Deployment (max. 3 tasks) to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2021 board.

CorinnaHillebrand_WMDE subscribed.

https://github.com/wmde/fundraising-banners/pull/770

ready for check at
https://www.wikipedia.de/?banner=B21WPDE_02-211119_ctrl
https://www.wikipedia.de/?banner=B21WPDE_02-211119_var

I set the start date to 17:00 today, test 01 will switch to 02 then.

@CorinnaHillebrand_WMDE There are quite some height differences in lower resolutions. Mainly, because of a breakpoint mismatch. I think the following changes to the variant banner should do it: