ParserOutput::addImage() current takes a string dbkey. For consistency with the other methods in ParserOutput (see T296023) this should take a LinkTarget|LazyLinkTarget instead.
This also means that this code in ::addImage($name,...):
$this->mImages[$name] = 1;
should be changed to store a list of LazyLinkTargets instead, and they can be deduplicated "at the last minute" when the LazyLinkTargets are resolved in a batch.
@cscott: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!