Page MenuHomePhabricator
Create Task
Maniphest T296049

[wmf.9 - ruwiki] Add link doesn't load
Closed, ResolvedPublic
Actions

Description

On ruwiki wmf.9 select 'Add a link' structured task and click to go to a suggested article.

  • The Add link functionality won't be present
  • The help panel tries to suggest Visual editor but fails to display the labels properly
  • Clicking on the VE tab won't switch to VE

Screen Shot 2021-11-18 at 3.50.52 PM.png (944×1 px, 373 KB)

The Console displayas several errors:
TypeError: Cannot read properties of undefined (reading 'minimumCaptionCharacterLength')
Uncaught TypeError: Cannot read properties of undefined (reading 'getDefaultMode')

Details

SubjectRepoBranchLines +/-
Lazy-load structured task JS filesmediawiki/extensions/GrowthExperimentswmf/1.38.0-wmf.9+92 -72
Lazy-load structured task JS filesmediawiki/extensions/GrowthExperimentsmaster+92 -72
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Nov 19 2021, 12:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2021, 12:33 AM
gerritbot added a comment.Nov 19 2021, 1:12 AM

Change 739952 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Lazy-load structured task JS files

https://gerrit.wikimedia.org/r/739952

gerritbot added a project: Patch-For-Review.Nov 19 2021, 1:12 AM
gerritbot added a comment.Nov 19 2021, 2:10 AM

Change 739837 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] Lazy-load structured task JS files

https://gerrit.wikimedia.org/r/739837

gerritbot added a comment.Nov 19 2021, 2:30 AM

Change 739952 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Lazy-load structured task JS files

https://gerrit.wikimedia.org/r/739952

gerritbot added a comment.Nov 19 2021, 2:38 AM

Change 739837 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] Lazy-load structured task JS files

https://gerrit.wikimedia.org/r/739837

Stashbot added a comment.Nov 19 2021, 2:54 AM

Mentioned in SAL (#wikimedia-operations) [2021-11-19T02:54:34Z] <tgr@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/GrowthExperiments/modules: Backport: [[gerrit:739837|Lazy-load structured task JS files (T296049)]] (duration: 00m 55s)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 19 2021, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 19 2021, 3:10 AM
Tgr added a comment.Nov 19 2021, 4:40 AM

I think this has been de facto QA-d, but I'll leave it to @Etonkovidova how to classify the ticket.

Tgr moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 19 2021, 4:40 AM
Tgr mentioned this in T296043: TypeError: undefined is not an object (evaluating 'this.currentCard.data.qualityGateIds').Nov 19 2021, 11:05 AM
Aklapper added a project: GrowthExperiments.Nov 20 2021, 10:13 PM
Aklapper edited subscribers, added: Urbanecm_WMF; removed: User-Urbanecm_WMF (Ambassador).

(Please don't add project tags as subscribers - thanks!)

Etonkovidova closed this task as Resolved.Nov 24 2021, 9:33 PM
Etonkovidova claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL