Should non-image file types be excluded from the recommendation API in the first place?

In T296053#7517338, @mewoph wrote:

Should non-image file types be excluded from the recommendation API in the first place?

That was my assumption too.

@mewoph @Etonkovidova -- we encountered this very same issue with video files. @Tgr also recommended that we just keep these pairings (article+video or article+audio) out of the queue. It's something that really should happen upstream with the algorithm, and so I'm going to save this as a requirement for the next iteration of the API. In the meantime, I think we should ignore this bug for Iteration 1 since it will be rare.

We can show a "no suggestions" error, that would be pretty easy. It would stay in the queue though, which is not a great experience. With the current behavior, you can accept or reject it, and while the editing interface won't look particularly good (I think the weird narrow shape at least would be fixed by the patch in T295922: [testwiki-wmf.9] Add image - small size image breaks caption box), it could be accepted/rejected, and the edit would work just fine.

In T296053#7517847, @MMiller_WMF wrote:

@mewoph @Etonkovidova -- we encountered this very same issue with video files. @Tgr also recommended that we just keep these pairings (article+video or article+audio) out of the queue. It's something that really should happen upstream with the algorithm, and so I'm going to save this as a requirement for the next iteration of the API. In the meantime, I think we should ignore this bug for Iteration 1 since it will be rare.

In T296053#7517903, @Tgr wrote:

We can show a "no suggestions" error, that would be pretty easy. It would stay in the queue though, which is not a great experience. With the current behavior, you can accept or reject it, and while the editing interface won't look particularly good (I think the weird narrow shape at least would be fixed by the patch in T295922: [testwiki-wmf.9] Add image - small size image breaks caption box), it could be accepted/rejected, and the edit would work just fine.

Is it possible to filter out audio files but keep video? I can see videos potentially being expected and a match, but audio files for an "Add a suggested image" task is quite unexpected.

We can treat audio and video differently if needed.

In T296053#7521086, @Tgr wrote:

We can treat audio and video differently if needed.

Great, thanks. Per our team discussion earlier I've created a next iteration task T296220 for handling video.

Can we close this task given T296333: Add an image: exclude non-images is being done for Iteration 1?