Page MenuHomePhabricator

Avoid using User::getOption
Open, MediumPublic

Description

User::getOption was soft deprecated and now need to be hard deprecated. So we need to remove using at least in the deployed extensions:

Deployed skins where we need to replace User::getOption callers:

  • Then we could hard deprecate User::getOption. -> Patch

Non Deployed extensions that still have usage of User::getOption:

  • BlueSpiceFoundation
  • MediaUploader
  • WikiLexicalData
  • BlueSpiceFlaggedRevsConnector
  • BlueSpiceSocial
  • OpenID
  • ArticleFeedbackv5
  • BlueSpiceEchoConnector
  • BlueSpiceExpiry
  • BlueSpiceExtendedSearch
  • CreateAPage
  • EditAccount
  • OnlineStatusBar
  • BlueSpiceAvatars
  • BlueSpicePrivacy
  • BlueSpiceReminder
  • BlueSpiceUniversalExport
  • BlueSpiceUserManager
  • CollapsibleVector
  • GoogleAuthenticator
  • PageForms
  • StickToThatLanguage
  • TranslateSvg
  • Video
  • Auth_remoteuser
  • BlogPage
  • BlueSpiceDashboards
  • BlueSpiceSocialProfile
  • BlueSpiceUEModuleBookPDF
  • BlueSpiceUEModuleHTML
  • CategoryWatch
  • Comments
  • ConfirmAccount
  • Drafts
  • EmailDiff
  • Favorites
  • GlobalContribs
  • HAWelcome
  • HSTS
  • JSBreadCrumbs
  • JsonData
  • LanguageSelector
  • LDAPUserInfo
  • LinkSuggest
  • LinkSuggest2
  • LiveChat
  • MediaWikiChat
  • NewsBox
  • OnlineStatus
  • OnlyRecentRecentChanges
  • ParserMigration
  • PerformanceInspector
  • SecureSessions
  • Theme
  • VEForAll

Non Deployed skins that still have usage of User::getOption:

  • BlueSpiceCalumma
  • Metrolook

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/BetaFeaturesmaster+9 -8
mediawiki/extensions/Echomaster+162 -113
mediawiki/extensions/WikimediaIncubatormaster+53 -16
mediawiki/coremaster+228 -83
mediawiki/extensions/TranslationNotificationsmaster+28 -15
mediawiki/extensions/Flowmaster+7 -4
mediawiki/extensions/MultimediaViewermaster+36 -13
mediawiki/extensions/Wikibasemaster+129 -39
mediawiki/extensions/Translatemaster+30 -9
mediawiki/extensions/GlobalPreferencesmaster+20 -14
mediawiki/skins/MinervaNeuemaster+29 -8
mediawiki/extensions/CodeMirrormaster+8 -3
mediawiki/extensions/CodeReviewmaster+4 -2
mediawiki/skins/Vectormaster+56 -29
mediawiki/extensions/ORESmaster+5 -3
mediawiki/extensions/FlaggedRevsmaster+8 -2
mediawiki/extensions/UploadWizardmaster+19 -5
mediawiki/extensions/ContentTranslationmaster+2 -1
mediawiki/extensions/TimedMediaHandlermaster+2 -1
mediawiki/extensions/MassMessagemaster+21 -3
mediawiki/extensions/EntitySchemamaster+9 -1
mediawiki/extensions/VisualEditormaster+49 -32
mediawiki/extensions/CirrusSearchmaster+139 -44
mediawiki/extensions/LiquidThreadsmaster+5 -3
mediawiki/extensions/WikimediaMessagesmaster+3 -4
mediawiki/extensions/FileImportermaster+3 -1
mediawiki/extensions/PagedTiffHandlermaster+4 -1
mediawiki/extensions/CodeEditormaster+18 -2
mediawiki/extensions/UserMergemaster+2 -2
mediawiki/extensions/wikihieromaster+19 -4
mediawiki/extensions/WikiLovemaster+4 -2
mediawiki/extensions/PageImagesmaster+2 -1
mediawiki/extensions/LdapAuthenticationmaster+3 -2
mediawiki/extensions/Gadgetsmaster+4 -1
mediawiki/extensions/FileExportermaster+0 -3
mediawiki/extensions/WikiEditormaster+5 -3
mediawiki/extensions/ProofreadPagemaster+8 -1
mediawiki/extensions/TwoColConflictmaster+5 -4
mediawiki/extensions/CentralAuthmaster+2 -2
mediawiki/extensions/GrowthExperimentsmaster+88 -30
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 741909 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/wikihiero@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741909

Change 741910 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/UploadWizard@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741910

Change 741942 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/VisualEditor@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741942

Change 741944 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/WikiEditor@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741944

Change 741947 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/UserMerge@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741947

Change 741971 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ProofreadPage@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741971

Change 741977 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/PagedTiffHandler@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741977

Change 741971 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741971

Change 742119 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/MultimediaViewer@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742119

Change 741944 abandoned by Vlad.shapik:

[mediawiki/extensions/WikiEditor@master] Avoid using User::getOption

Reason:

This change was already in progress in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/736880

https://gerrit.wikimedia.org/r/741944

Change 742123 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/Gadgets@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742123

Change 742125 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/FileImporter@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742125

Change 742139 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Wikibase@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742139

Change 742145 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/FileExporter@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742145

Change 742145 merged by jenkins-bot:

[mediawiki/extensions/FileExporter@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742145

Change 742123 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742123

Change 741862 merged by jenkins-bot:

[mediawiki/extensions/LdapAuthentication@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741862

Change 741863 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741863

Change 741732 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741732

Change 741909 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741909

Change 741947 merged by jenkins-bot:

[mediawiki/extensions/UserMerge@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741947

Change 740846 merged by jenkins-bot:

[mediawiki/extensions/CodeEditor@master] Avoid using User::getOption and inject service UserOptionsLookup

https://gerrit.wikimedia.org/r/740846

Change 741977 merged by jenkins-bot:

[mediawiki/extensions/PagedTiffHandler@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741977

Change 742125 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742125

Change 740848 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/740848

Change 740594 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/740594

Change 741087 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741087

Change 741674 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741674

Change 741942 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741942

Change 742455 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/FlaggedRevs@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742455

Change 742456 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/ContentTranslation@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742456

Change 742463 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/GlobalPreferences@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742463

Change 740809 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/740809

Change 741158 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741158

Change 741910 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/741910

Change 742456 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742456

Change 742455 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742455

Change 742512 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CodeMirror@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742512

Change 742516 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CodeReview@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742516

Change 742521 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ORES@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742521

Change 742521 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742521

Change 740833 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/740833

Change 742694 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/TranslationNotifications@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742694

Change 742700 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Translate@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742700

Change 742755 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/Flow@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742755

Change 742516 merged by jenkins-bot:

[mediawiki/extensions/CodeReview@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742516

Change 742512 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742512

Change 742766 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BetaFeatures@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742766

Change 742774 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/WikimediaIncubator@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742774

Change 740782 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/740782

Change 742463 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742463

Change 742700 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742700

roman-stolar updated the task description. (Show Details)
roman-stolar updated the task description. (Show Details)

Change 742139 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742139

Change 742977 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] [DNM] Hard deprecate User::getOption.

https://gerrit.wikimedia.org/r/742977

Change 742992 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/Echo@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742992

Change 742755 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742755

Change 742119 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742119

Change 742694 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Avoid using User::getOption

https://gerrit.wikimedia.org/r/742694

Change 742766 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Avoid using User::getOption() method

https://gerrit.wikimedia.org/r/742766