Page MenuHomePhabricator

Avoid using User::getOption
Closed, ResolvedPublic

Description

User::getOption was soft deprecated and now need to be hard deprecated. So we need to remove using at least in the deployed extensions:

Deployed skins where we need to replace User::getOption callers:

  • Remove usage of User::getOption from core. -> Patch
  • Then we could hard deprecate User::getOption. -> Patch

Non Deployed but tarball extensions that still have usage of User::getOption:

Non Deployed extensions that still have usage of User::getOption:

Non Deployed skins that still have usage of User::getOption:

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/BlueSpiceAvatarsREL1_39-4.3.x+2 -2
mediawiki/extensions/BlueSpiceAvatarsREL1_39+2 -2
mediawiki/extensions/BlueSpiceUEModuleHTMLREL1_39-4.3.x+2 -1
mediawiki/extensions/BlueSpiceUEModuleHTMLREL1_39+2 -1
mediawiki/extensions/TinyMCEREL1_39+9 -2
mediawiki/extensions/PerformanceInspectorREL1_39+11 -2
mediawiki/extensions/PerformanceInspectormaster+11 -2
mediawiki/extensions/BlueSpiceAvatarsmaster+2 -2
mediawiki/extensions/SocialProfilemaster+12 -3
mediawiki/extensions/BlueSpiceUEModuleHTMLmaster+2 -1
mediawiki/skins/BlueSpiceCalummamaster+5 -3
mediawiki/extensions/WhosOnlinemaster+5 -4
mediawiki/skins/PonchoREL1_39+14 -5
mediawiki/extensions/TinyMCEmaster+9 -2
mediawiki/extensions/WikiForummaster+2 -1
mediawiki/skins/Ponchomaster+14 -5
mediawiki/extensions/ReplaceTextREL1_39+2 -1
mediawiki/extensions/ReplaceTextmaster+2 -1
mediawiki/coremaster+5 -1
mediawiki/extensions/PageFormsmaster+23 -2
mediawiki/extensions/SecureSessionsmaster+6 -3
mediawiki/skins/Metrolookmaster+4 -1
mediawiki/extensions/VEForAllmaster+8 -1
mediawiki/extensions/LinkSuggest2master+10 -1
mediawiki/extensions/ParserMigrationmaster+4 -1
mediawiki/extensions/MediaUploadermaster+14 -5
mediawiki/extensions/OnlineStatusmaster+23 -4
mediawiki/extensions/GoogleAuthenticatormaster+7 -6
mediawiki/extensions/StickToThatLanguagemaster+24 -8
mediawiki/extensions/MediaWikiChatmaster+18 -3
mediawiki/extensions/OnlyRecentRecentChangesmaster+6 -2
mediawiki/extensions/CollapsibleVectormaster+4 -1
mediawiki/extensions/HAWelcomemaster+2 -1
mediawiki/extensions/LinkSuggestmaster+3 -2
mediawiki/extensions/JSBreadCrumbsmaster+10 -9
mediawiki/extensions/LDAPUserInfomaster+4 -9
mediawiki/extensions/OnlineStatusBarmaster+16 -7
mediawiki/extensions/CreateAPagemaster+214 -219
mediawiki/extensions/CategoryWatchmaster+11 -2
mediawiki/extensions/BlogPagemaster+6 -3
mediawiki/extensions/JsonDatamaster+3 -2
mediawiki/extensions/Videomaster+7 -3
mediawiki/coremaster+21 -10
mediawiki/extensions/Draftsmaster+5 -2
mediawiki/extensions/EmailDiffmaster+5 -2
mediawiki/extensions/LiveChatmaster+3 -1
mediawiki/extensions/TranslateSvgmaster+2 -1
mediawiki/extensions/ConfirmAccountmaster+2 -1
mediawiki/extensions/NewsBoxmaster+6 -4
mediawiki/extensions/GlobalContribsmaster+3 -1
mediawiki/extensions/LanguageSelectormaster+4 -4
mediawiki/extensions/Auth_remoteusermaster+11 -8
mediawiki/extensions/OpenIDmaster+4 -3
mediawiki/extensions/Commentsmaster+2 -1
mediawiki/extensions/BlueSpiceEchoConnectormaster+17 -6
mediawiki/coreREL1_38+6 -2
mediawiki/coremaster+24 -9
mediawiki/coremaster+29 -6
mediawiki/coremaster+36 -15
mediawiki/coremaster+18 -11
mediawiki/coremaster+15 -2
mediawiki/extensions/Thememaster+10 -10
mediawiki/coremaster+6 -2
mediawiki/coremaster+35 -10
mediawiki/coremaster+5 -1
mediawiki/coremaster+9 -1
mediawiki/coremaster+14 -10
mediawiki/extensions/Echomaster+164 -123
mediawiki/extensions/WikimediaIncubatormaster+53 -16
mediawiki/extensions/BetaFeaturesmaster+9 -8
mediawiki/extensions/TranslationNotificationsmaster+28 -15
mediawiki/extensions/Flowmaster+7 -4
mediawiki/extensions/MultimediaViewermaster+36 -13
mediawiki/extensions/Wikibasemaster+129 -39
mediawiki/extensions/Translatemaster+30 -9
mediawiki/extensions/GlobalPreferencesmaster+20 -14
mediawiki/skins/MinervaNeuemaster+29 -8
mediawiki/extensions/CodeMirrormaster+8 -3
mediawiki/extensions/CodeReviewmaster+4 -2
mediawiki/skins/Vectormaster+56 -29
mediawiki/extensions/ORESmaster+5 -3
mediawiki/extensions/FlaggedRevsmaster+8 -2
mediawiki/extensions/UploadWizardmaster+19 -5
mediawiki/extensions/ContentTranslationmaster+2 -1
mediawiki/extensions/TimedMediaHandlermaster+2 -1
mediawiki/extensions/MassMessagemaster+21 -3
mediawiki/extensions/EntitySchemamaster+9 -1
mediawiki/extensions/VisualEditormaster+49 -32
mediawiki/extensions/CirrusSearchmaster+139 -44
mediawiki/extensions/LiquidThreadsmaster+5 -3
mediawiki/extensions/WikimediaMessagesmaster+3 -4
mediawiki/extensions/FileImportermaster+3 -1
mediawiki/extensions/PagedTiffHandlermaster+4 -1
mediawiki/extensions/CodeEditormaster+18 -2
mediawiki/extensions/UserMergemaster+2 -2
mediawiki/extensions/wikihieromaster+19 -4
mediawiki/extensions/WikiLovemaster+4 -2
mediawiki/extensions/PageImagesmaster+2 -1
mediawiki/extensions/LdapAuthenticationmaster+3 -2
mediawiki/extensions/Gadgetsmaster+4 -1
mediawiki/extensions/FileExportermaster+0 -3
mediawiki/extensions/WikiEditormaster+5 -3
mediawiki/extensions/ProofreadPagemaster+8 -1
mediawiki/extensions/TwoColConflictmaster+5 -4
mediawiki/extensions/CentralAuthmaster+2 -2
mediawiki/extensions/GrowthExperimentsmaster+88 -30
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 826657 merged by jenkins-bot:

[mediawiki/extensions/StickToThatLanguage@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826657

Change 826305 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826305

Change 826822 merged by jenkins-bot:

[mediawiki/extensions/GoogleAuthenticator@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826822

Change 826656 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatus@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826656

Change 824823 merged by jenkins-bot:

[mediawiki/extensions/MediaUploader@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/824823

Change 826909 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/ParserMigration@master] Use UserOptionsManager::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826909

Change 826909 merged by jenkins-bot:

[mediawiki/extensions/ParserMigration@master] Use UserOptionsManager::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826909

Change 826935 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/SecureSessions@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826935

Change 826936 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/VEForAll@master] Use UserOptionsManager::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826936

Change 826938 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Metrolook@master] Use UserOptionsManager::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826938

Change 826949 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/LinkSuggest2@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826949

Change 826949 merged by jenkins-bot:

[mediawiki/extensions/LinkSuggest2@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826949

Change 826936 merged by jenkins-bot:

[mediawiki/extensions/VEForAll@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826936

Change 826938 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826938

Change 826935 merged by jenkins-bot:

[mediawiki/extensions/SecureSessions@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/826935

Change 745520 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate User::getOption

https://gerrit.wikimedia.org/r/745520

Why SemanticMediaWiki is not on the list of extensions in the task summary? It should be there per the stable interface policy.

The hard-deprecation caused a flood of log spam during today's translatewiki.net deployment, which was an additional hurdle for an already complicated deployment.

Change 830731 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/ReplaceText@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/830731

Change 830731 merged by jenkins-bot:

[mediawiki/extensions/ReplaceText@master] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/830731

Change 830821 had a related patch set uploaded (by Zabe; author: Fomafix):

[mediawiki/extensions/ReplaceText@REL1_39] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/830821

Change 830821 merged by jenkins-bot:

[mediawiki/extensions/ReplaceText@REL1_39] Use UserOptionsLookup::getOption instead of deprecated User::getOption

https://gerrit.wikimedia.org/r/830821

Why SemanticMediaWiki is not on the list of extensions in the task summary? It should be there per the stable interface policy.

The hard-deprecation caused a flood of log spam during today's translatewiki.net deployment, which was an additional hurdle for an already complicated deployment.

https://www.mediawiki.org/wiki/Stable_interface_policy#Hard_deprecation says "no longer used in any Wikimedia maintained code", which seems to happen when looking at the list of resolved extensions of this task.

Change 830911 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WhosOnline@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830911

Change 830912 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiForum@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830912

Change 830913 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TinyMCE@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830913

The policy also says this about soft deprecation

Developers or teams deprecating code SHOULD actively support removal of usages in code in the MediaWiki ecosystem, especially in popular extensions. This includes making maintainers aware of the deprecation as well as creating or reviewing patches removing usages.

To be fair, I don't remember if the policy was active when the soft deprecation happened.

Change 830915 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SocialProfile@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830915

Change 830916 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceUEModuleHTML@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830916

Change 830920 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/BlueSpiceCalumma@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830920

Change 830201 had a related patch set uploaded (by Umherirrender; author: Jdlrobson):

[mediawiki/skins/Poncho@master] Fixes User::getOption was deprecated in MediaWiki 1.35

https://gerrit.wikimedia.org/r/830201

Change 830201 merged by jenkins-bot:

[mediawiki/skins/Poncho@master] Fixes User::getOption was deprecated in MediaWiki 1.35

https://gerrit.wikimedia.org/r/830201

Change 830912 merged by jenkins-bot:

[mediawiki/extensions/WikiForum@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830912

Change 830913 merged by jenkins-bot:

[mediawiki/extensions/TinyMCE@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830913

Change 831966 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Poncho@REL1_39] Fixes User::getOption was deprecated in MediaWiki 1.35

https://gerrit.wikimedia.org/r/831966

Change 831966 merged by jenkins-bot:

[mediawiki/skins/Poncho@REL1_39] Fixes User::getOption was deprecated in MediaWiki 1.35

https://gerrit.wikimedia.org/r/831966

Change 830911 merged by Umherirrender:

[mediawiki/extensions/WhosOnline@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830911

Change 830920 merged by Umherirrender:

[mediawiki/skins/BlueSpiceCalumma@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830920

Change 830916 merged by Umherirrender:

[mediawiki/extensions/BlueSpiceUEModuleHTML@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830916

Change 830915 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/830915

Change 834654 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/BlueSpiceAvatars@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/834654

Umherirrender removed a project: Patch-For-Review.
Umherirrender updated the task description. (Show Details)

Change 834654 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceAvatars@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/834654

Change 856039 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PerformanceInspector@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/856039

Change 856039 merged by jenkins-bot:

[mediawiki/extensions/PerformanceInspector@master] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/856039

Thanks Umherirrender!

Change 863361 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PerformanceInspector@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/863361

Change 863361 merged by jenkins-bot:

[mediawiki/extensions/PerformanceInspector@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/863361

Change 863363 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TinyMCE@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/863363

Change 863363 merged by jenkins-bot:

[mediawiki/extensions/TinyMCE@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/863363

Change 942471 had a related patch set uploaded (by Hslater; author: Umherirrender):

[mediawiki/extensions/BlueSpiceUEModuleHTML@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942471

Change 942472 had a related patch set uploaded (by Hslater; author: Umherirrender):

[mediawiki/extensions/BlueSpiceUEModuleHTML@REL1_39-4.3.x] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942472

Change 942473 had a related patch set uploaded (by Hslater; author: Fomafix):

[mediawiki/extensions/BlueSpiceAvatars@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942473

Change 942471 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceUEModuleHTML@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942471

Change 942472 merged by Hslater:

[mediawiki/extensions/BlueSpiceUEModuleHTML@REL1_39-4.3.x] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942472

Change 942474 had a related patch set uploaded (by Hslater; author: Fomafix):

[mediawiki/extensions/BlueSpiceAvatars@REL1_39-4.3.x] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942474

Change 942473 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceAvatars@REL1_39] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942473

Change 942474 merged by Hslater:

[mediawiki/extensions/BlueSpiceAvatars@REL1_39-4.3.x] Replace deprecated User::getOption

https://gerrit.wikimedia.org/r/942474