Page MenuHomePhabricator
Create Task
Maniphest T296112

action=edit&section=new strips '0' as section title
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

  1. edit any existing page using ?action=edit&section=new
  2. type 0 as section title (in wpSummary) and some body text
  3. save the page

Expected:
wikitext added:

== 0 ==
body text

Actual behaviour:
the section title (== 0 ==) is stripped and the body text simply is appended to the page content.

Remarks

  • While creating a page using ?action=edit&section=new the section title is not stripped
  • Same behaviour can be observed with the new discussion tool

Details

SubjectRepoBranchLines +/-
Allow inserting new sections named '0'mediawiki/coreREL1_37+1 -1
Allow inserting new sections named '0'mediawiki/coreREL1_36+1 -1
Allow inserting new sections named '0'mediawiki/coreREL1_35+1 -1
Allow inserting new sections named '0'mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

hgzh created this task.Nov 19 2021, 9:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2021, 9:34 PM
hgzh updated the task description. (Show Details)Nov 19 2021, 9:35 PM
cscott subscribed.Nov 19 2021, 10:47 PM

I can reproduce this locally on current git master.

gerritbot added a comment.Nov 20 2021, 3:20 AM

Change 740292 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740292

gerritbot added a project: Patch-For-Review.Nov 20 2021, 3:20 AM
cscott claimed this task.Nov 20 2021, 3:21 AM
PatchDemoBot added a comment.Nov 20 2021, 4:44 AM

Test wiki created on Patch Demo by Legoktm using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/27561c18e4/w/

gerritbot added a comment.Nov 20 2021, 5:08 AM

Change 740292 merged by jenkins-bot:

[mediawiki/core@master] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740292

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2021, 5:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 20 2021, 6:00 AM
gerritbot added a comment.Nov 20 2021, 6:14 AM

Change 740249 had a related patch set uploaded (by Legoktm; author: C. Scott Ananian):

[mediawiki/core@REL1_37] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740249

gerritbot added a project: Patch-For-Review.Nov 20 2021, 6:14 AM

Change 740250 had a related patch set uploaded (by Legoktm; author: C. Scott Ananian):

[mediawiki/core@REL1_36] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740250

gerritbot added a comment.Nov 20 2021, 6:15 AM

Change 740251 had a related patch set uploaded (by Legoktm; author: C. Scott Ananian):

[mediawiki/core@REL1_35] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740251

gerritbot added a comment.Nov 20 2021, 6:24 AM

Change 740251 merged by jenkins-bot:

[mediawiki/core@REL1_35] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740251

gerritbot added a comment.Nov 20 2021, 6:25 AM

Change 740249 merged by jenkins-bot:

[mediawiki/core@REL1_37] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740249

gerritbot added a comment.Nov 20 2021, 6:27 AM

Change 740250 merged by jenkins-bot:

[mediawiki/core@REL1_36] Allow inserting new sections named '0'

https://gerrit.wikimedia.org/r/740250

Legoktm closed this task as Resolved.Nov 20 2021, 6:46 AM
ReleaseTaggerBot added projects: MW-1.36-notes, MW-1.35-notes, MW-1.37-notes.Nov 20 2021, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 20 2021, 7:10 AM
hgzh awarded a token.Nov 20 2021, 8:02 AM
PatchDemoBot added a comment.Dec 4 2021, 9:56 PM

Test wiki on Patch demo by Legoktm using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/27561c18e4/w/

cscott mentioned this in T349344: Wikipedia iOS app displays no page title on “0”.Oct 26 2023, 2:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL